Page MenuHomePhabricator

Group assignment should be removed and handled in LocalSettings.php
Closed, DeclinedPublic

Description

These two lines should not be in CheckUser.php:

$wgGroupPermissions['checkuser']['checkuser'] = true;
$wgGroupPermissions['checkuser']['checkuser-log'] = true;

I give CheckUser to my sysops and don't use a dedicated group for it. Having to undo these group assignments is not the best way to go, so just remove those lines and ask people to install it this way in LocalSettings.php:

require_once ( "$IP/extensions/CheckUser/CheckUser.php" );
$wgGroupPermissions['checkuser']['checkuser'] = true;
$wgGroupPermissions['checkuser']['checkuser-log'] = true;

And then of course we can choose to assign the permissions to whatever group without having to undo the assignments made in CheckUser.php.


Version: master
Severity: trivial

Details

Reference
bz43389

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:05 AM
bzimport added a project: CheckUser.
bzimport set Reference to bz43389.

Maybe we should have this as a general rule for extensions...

Change 124324 had a related patch set uploaded by John F. Lewis:
Remove default group assignment

https://gerrit.wikimedia.org/r/124324

Change 124324 abandoned by John F. Lewis:
Remove default group assignment

Reason:
Per Tim.

https://gerrit.wikimedia.org/r/124324