From https://gerrit.wikimedia.org/r/#/c/39490/
"Recent changes seem to have broken mod behavior for a lot of users. Notably, it broke the coordinate templates on a bunch of wikis."
This is likely from a mix of:
https://gerrit.wikimedia.org/r/#/c/37368/ and https://gerrit.wikimedia.org/r/#/c/38278/
Does anyone have any examples of what is "broken"? If so, they should be added to the PHPUnit tests for future regression prevention. If no one does, it might be easiest just to deploy it again, and wait for the complaints... ;D
I'm guessing the main line at fault is:
- $stack[] = $left % $right;
+ $stack[] = fmod( (float)$left, (float)$right );
which then became:
- $stack[] = fmod( (float)$left, (float)$right );
+ $stack[] = fmod( (double)$left, (double)$right );
So the deployed code should have been:
$stack[] = fmod( (double)$left, (double)$right );
Version: unspecified
Severity: major