Page MenuHomePhabricator

Click outside of Guider tooltip to close
Closed, ResolvedPublic

Description

Author: massaf

Description:
We should add an option to the jQuery plugin to be able to click outside of the guider tooltip to close it, rather than clicking the dismiss X or a button. With persistent tooltips, it's best for accessibility to redundantly cover all the methods the user may want to use to close it.


Version: unspecified
Severity: enhancement

Details

Reference
bz43642

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:21 AM
bzimport set Reference to bz43642.

swalling wrote:

+1.

This is an important usability enhancement.

swalling wrote:

After playing around with our various implementations of guiders again tonight (in Special:GettingStarted, the GettingStarted tour, etc.) I once again find it necessary that we add this to the feature for all tours. Modal windows should always provide as many vectors to close them as we can, and clicking outside to close is the largest target area.

Should it close the current step, or end the tour?

Okay, I've submitted a Gerrit to have them all close methods (ESC, X, click outside) work like that, *except* the checkbox/button combo in https://bugzilla.wikimedia.org/show_bug.cgi?id=44123 .

https://gerrit.wikimedia.org/r/#/c/44952/

There's a bug. It needs to get unbound when the Guider is hidden, or you can't click anything else on the page.

The library change is complete as of https://gerrit.wikimedia.org/r/#/c/45295/ (including the sub-bug in my last comment), which is merged.

Patch set 2 of https://gerrit.wikimedia.org/r/#/c/44752/ picks that fix up. It's a bigger change and is pending review.