Page MenuHomePhabricator

Add unit tests for GuidedTour
Closed, ResolvedPublic

Description

Add some unit tests for GuidedTour. These should focus on our logic, e.g. the shouldSkip methods, pingServer, initGuider wrapper, etc.


Version: master
Severity: normal

Details

Reference
bz43654

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:22 AM
bzimport set Reference to bz43654.

Some QUnit tests have now been added, though more are needed.

Matthew Flaschen: You assigned this issue to yourself 12 months ago. Could you please provide a status update and inform us whether you are still working (or still plan to work) on this issue?
Only in case you do not plan to work on this issue anymore, should the assignee be set back to default and the bug status changed from ASSIGNED to NEW/UNCONFIRMED? Thanks.

This is kind of a general bug. However, I'm working on an API change right now (https://gerrit.wikimedia.org/r/#/c/116228/), so this is a good time to work on unit tests.

I'll try to add some more, then mark this fixed. We can add more tests in the future, and possibly make bugs if something in particular needs to be tested but isn't yet.