Page MenuHomePhabricator

[tools/code-utils] read_wfMsgCalls.py still uses mediawiki/trunk/phase3
Closed, DeclinedPublic

Description

./read_wfMsgCalls.py
(...)
OSError: [Errno 2] No such file or directory: 'mediawiki/trunk/phase3'

There are four phase3 occurrences in the file.


Version: unspecified
Severity: trivial

Details

Reference
bz43777

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:30 AM
bzimport set Reference to bz43777.

You should just change the two first occurrences with '.' and the two last with 'core' and execute it in the root directory of the source tree of mediawiki.

Not sure if it should be considered as a bug since the path should be changed to adapt to the source tree of MW whose the location is wanted by the specific user.

You should provide a sensible default location.

The migration to Git version control system and Gerrit version control dropped "trunk" and "phase3".

Code is now in mediawiki/core, your script in mediawiki/tools/code-utils.

I personally used for a new script in mediawiki/tools/release "../../core/" to better reflect the Git hierarchy but I'm not sure this is really useful. So other ways have to be considered.

Feel free to see how other scripts solve the directory problem (some by an environment variable, some by ., some by a directory argument).

Ok, you’re right. I learned last week how to use Git+Gerrit, I should now practice. I will probably not have time to do this change before at least one month; if you want use the script before you can change on your local copy.

Change 118263 had a related patch set uploaded by Seb35:
Convert read_wfMsgCalls.py to Git

https://gerrit.wikimedia.org/r/118263

Change 118263 abandoned by Hashar:
Convert read_wfMsgCalls.py to Git

Reason:
Script is deleted with https://gerrit.wikimedia.org/r/#/c/162205/ . Would be better done has a PHP CodeSniffer rule :)

https://gerrit.wikimedia.org/r/118263

Script deleted because obsolete. Hashar propose a PHP CodeSniffer rule as a possible replacement.