Page MenuHomePhabricator

VisualEditor: Port MW core changes back to 1.19.x, 1.20.x and 1.21.x series so VE can run on them
Closed, DeclinedPublic

Description

Author: Coiby.Xu

Description:
I try a clean install of MW 1.20.2 and also install VE and Parsoid extension. When click "VisualEditor" button, the VE doesn't appear and there's a js error: "Uncaught TypeError: Cannot read property 'error' of null".


Version: unspecified
Severity: enhancement

Details

Reference
bz43898

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:38 AM
bzimport set Reference to bz43898.

Hi Coiby,
which user interface skin do you use?
Is this MediaWiki installation publicly accessible somewhere?
Which versions of VE and Parsoid versions do you use?

This is correct - minimum current version of MW for the VE code is 1.21/wmf5 (and this may go up as we add more functionality to MW core so that VE can work; it is possible that these changes will get back-ported to 1.19 and 1.20 by some volunteers, but we at WMF won't be looking at this whilst the extension is still in an experimental stage.

Will change this to an enhancement for that to be done, with low priority (reflecting that if a volunteer wants to do it, that'd be great).

See my comment on the wikitech-l mailing list thread: http://lists.wikimedia.org/pipermail/wikitech-l/2013-January/065532.html

Have added this to the Extension page on MediaWiki.org -
https://www.mediawiki.org/w/index.php?title=Extension:VisualEditor&diff=628258&oldid=610234

Coiby.Xu wrote:

Hi Andre,
The skin I use is Vector. This Mediawiki is in the local network thus can't be accessed from outside:(
The version of VE is 72c121684c6edb6ab580258676759f62e3efd471 and Parsoid's is aa34a80a6e43fe4fe6c5a95b465bf10dee3ed922.

Hi Coiby,
which user interface skin do you use?
Is this MediaWiki installation publicly accessible somewhere?
Which versions of VE and Parsoid versions do you use?

Coiby.Xu wrote:

Not really, I find it works on 1.20.0 :)

This is correct - minimum current version of MW for the VE code is 1.21/wmf5
(and this may go up as we add more functionality to MW core so that VE can
work; it is possible that these changes will get back-ported to 1.19 and 1.20
by some volunteers, but we at WMF won't be looking at this whilst the
extension
is still in an experimental stage.

Will change this to an enhancement for that to be done, with low priority
(reflecting that if a volunteer wants to do it, that'd be great).

See my comment on the wikitech-l mailing list thread:
http://lists.wikimedia.org/pipermail/wikitech-l/2013-January/065532.html

Have added this to the Extension page on MediaWiki.org -
https://www.mediawiki.org/w/index.php?title=Extension:
VisualEditor&diff=628258&oldid=610234

Coiby.Xu wrote:

Suddenly VE gave such error:"Uncaught TypeError: Cannot call method 'enable' of null" while it was normal a few days. I'm not sure if that error is related to this bug.

Copying Mark - Mark, what's policy for backporting functionality changes in core so that people can use extensions?

(In reply to comment #6)

Copying Mark - Mark, what's policy for backporting functionality changes in
core so that people can use extensions?

James: Have specific commits been identified?
I guess it highly depends on the complexity of the task...

(In reply to comment #6)

Copying Mark - Mark, what's policy for backporting functionality changes in
core so that people can use extensions?

Andre is right -- depends on the complexity. We did have some discussion of this on Wikitech-l, but I don't think a final decision was made.

I would suggest creating a backport and then ask for a review of it. If a person can be found to implement and support the backport, I don't have a problem with shipping a 1.19 with it.

(In reply to comment #8)

I would suggest creating a backport and then ask for a review of it. If a
person can be found to implement and support the backport, I don't have a
problem with shipping a 1.19 with it.

Thanks Mark; marking as lowest priority as (as said above) WMF won't be working on this, but if a third party would like to we'd be happy to help them out.

Now that 1.23.x is released I suppose this is unnecessary.