Page MenuHomePhabricator
Create Task
Maniphest T45956

Rename $wmf* to $wmg* in wmf-config
Closed, ResolvedPublic
Actions

Description

With https://gerrit.wikimedia.org/r/#/c/39056/ we renamed the old $realm to $wmfRealm. Tim mentioned:

It should be $wmgRealm, for consistency with other globals.
wmg = Wikimedia global, wmf = Wikimedia function.

We probably want to do that after the EQIAD migration though.

We can find them in operations/mediawiki-config with:

git grep -h -o -P '\$wmf.+?\b'|sort|uniq -c|sort -rn

As of Feb 4th 2020 we had:

57 $wmfConfigDir
53 $wmfRealm
36 $wmfAllServices
34 $wmfSwiftConfig
32 $wmfDatacenter
24 $wmfLocalServices
22 $wmfMasterDatacenter
15 $wmfHostnames
13 $wmfStandardAutoPromote
11 $wmfDbconfigFromEtcd
10 $wmfUdp2logDest
 6 $wmfSwiftShardLocal
 6 $wmfServiceConfig
 5 $wmfSwiftShardCommon
 5 $wmfPhabricatorApiToken
 4 $wmfMasterServices
 4 $wmfGerritApiUser
 4 $wmfGerritApiPassword
 3 $wmfSwiftBigWikis
 3 $wmfEtcdLastModifiedIndex
 1 $wmfUseRestbaseVRS

Details

Reference
bz43956
SubjectRepoBranchLines +/-
Migrate $wmfRealm calls to $wmgRealmoperations/mediawiki-configmaster+51 -51
Stop writing to $wmfSwiftConfigoperations/mediawiki-configmaster+0 -3
Migrate $wmfSwiftConfig to $wmgSwiftConfigoperations/mediawiki-configmaster+31 -31
Write the same value to wmgSwiftConfig as to wmfSwiftConfigoperations/mediawiki-configmaster+6 -3
Stop writing to $wmfUdp2logDestoperations/mediawiki-configmaster+2 -3
Migrate $wmfUdp2logDest to $wmgUdp2logDestoperations/mediawiki-configmaster+7 -7
Migrate $wmfConfigDir to $configDiroperations/mediawiki-configmaster+4 -4
Stop writing to $wmfUsingKubernetesoperations/mediawiki-configmaster+1 -1
Migrate $wmfUsingKubernetes to $wmgUsingKubernetesoperations/mediawiki-configmaster+3 -3
Start writing to $wmgUsingKubernetes the same value as to $wmfUsingKubernetesoperations/mediawiki-configmaster+1 -1
tests: rename $wmfConfigDir to $configDiroperations/mediawiki-configmaster+9 -9
Start writing to $wmgUdp2logDest the same value as to $wmfUdp2logDestoperations/mediawiki-configmaster+3 -2
Start writing to $wmgLocalServices the same value as to $wmfLocalServicesoperations/mediawiki-configmaster+5 -2
Stop writing to $wmfLocalServicesoperations/mediawiki-configmaster+1 -4
Migrate $wmfLocalServices to $wmgLocalServicesoperations/mediawiki-configmaster+40 -40
Migrate $wmfServiceConfig to $wmgServiceConfigoperations/mediawiki-configmaster+5 -5
Stop writing to $wmfAllServicesoperations/mediawiki-configmaster+1 -4
Migrate $wmfAllServices to $wmgAllServicesoperations/mediawiki-configmaster+26 -26
Start writing to $wmgAllServices the same value as to $wmfAllServicesoperations/mediawiki-configmaster+12 -9
Use $wmgUseRestbaseVRS in commentoperations/mediawiki-configmaster+1 -1
Stop writing to certain $wmf* global variablesoperations/mediawiki-configmaster+3 -11
Stop writing to $wmfDatacenter(s)operations/mediawiki-configmaster+6 -9
Migrate away from $wmfDbconfigFromEtcdoperations/mediawiki-configmaster+10 -10
Migrate wmfDatacenter(s) to wmgDatacenter(s)operations/mediawiki-configmaster+34 -34
wikitech_private: stop writing to wmf* constantsoperations/puppetproduction+0 -3
wikitech: migrate wmf* to wmg*operations/mediawiki-configmaster+21 -21
wikitech: migrate wmf* to wmg*operations/mediawiki-configmaster+21 -21
wmf-config: Use __DIR__ instead of "$IP/../wmf-config"operations/mediawiki-configmaster+32 -34
wikitech_private: write to wmg* constantsoperations/puppetproduction+3 -0
Write the same value to $wmgDatacenter(s) as to $wmfDatacenter(s)operations/mediawiki-configmaster+9 -6
wmf-config: Use __DIR__ instead of re-using an unintended globaloperations/mediawiki-configmaster+6 -7
filebackend: migrate $wmfSwift* to $wmgSwift*operations/mediawiki-configmaster+12 -12
Start writing to $wmgConfigDir the same value as to $wmfConfigDiroperations/mediawiki-configmaster+8 -7
Migrate $wmfStandardAutoPromote to $wmgStandardAutoPromoteoperations/mediawiki-configmaster+13 -13
Stop writing to $wmfRealmoperations/mediawiki-configmaster+4 -7
Migrate calls of wmf* constants to wmg* constantsoperations/mediawiki-configmaster+14 -14
Consistently write to $wmgRealm the same value as to $wmfRealmoperations/mediawiki-configmaster+6 -3
Renaming $wmfEtcdLastModifiedIndex to $wmgEtcdLastModifiedIndexoperations/mediawiki-configmaster+4 -4
Start writing to some wmg* constantsoperations/mediawiki-configmaster+17 -11
Migrate wmfHostnames to wmgHostnamesoperations/mediawiki-configmaster+16 -16
Complete wmfRealm to wmgRealmoperations/mediawiki-configmaster+51 -51
Finish $wmfRealm to $wmgRealmoperations/mediawiki-configmaster+56 -56
Rename $wmfRealm to $wmgRealmmediawiki/extensions/WikimediaMaintenancemaster+7 -7
Rename $wmfRealm to $wmgRealmmediawiki/extensions/WikimediaMessagesmaster+3 -3
Start renaming $wmfRealm to $wmgRealm in MWRealm.phpoperations/mediawiki-configmaster+3 -3
$wmf* -> $wmg*operations/mediawiki-configmaster+219 -233
Rename $wmf* to $wmg* in wmf-config and tests folderoperations/mediawiki-configmaster+311 -311
Renamed $wmf* to $wmg* for consistencymediawiki/extensions/WikimediaMaintenancewmf/1.26wmf18+6 -6
Rename wmfVersionNumber to wmgVersionNumberoperations/mediawiki-configmaster+13 -13
Renamed $wmf* to $wmg* for consistencymediawiki/extensions/WikimediaMaintenancewmf/1.26wmf17+6 -6
Renamed $wmf* to $wmg* for consistencymediawiki/extensions/WikimediaMaintenancemaster+6 -6
Show related patches Customize query in gerrit

Revisions and Commits

rOMWC Wikimedia - MediaWiki Config
rOMWC63cceecc6e3c $wmf* -> $wmg*

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Mar 10 2022, 7:09 PM

Change 769760 abandoned by Zabe:

[operations/mediawiki-config@master] wikitech: migrate wmf* to wmg*

Reason:

https://gerrit.wikimedia.org/r/769760

gerritbot added a comment.Mar 12 2022, 6:21 PM

Change 770102 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/puppet@production] wikitech_private: stop writing to wmf* constants

https://gerrit.wikimedia.org/r/770102

gerritbot added a comment.Mar 14 2022, 1:07 PM

Change 769750 merged by jenkins-bot:

[operations/mediawiki-config@master] wikitech: migrate wmf* to wmg*

https://gerrit.wikimedia.org/r/769750

Stashbot added a comment.Mar 14 2022, 1:10 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-14T13:10:58Z] <urbanecm@deploy1002> Synchronized wmf-config/wikitech.php: 95f376a: wikitech: migrate wmf* to wmg* (T45956) (duration: 00m 48s)

gerritbot added a comment.Mar 15 2022, 4:23 PM

Change 770102 merged by RLazarus:

[operations/puppet@production] wikitech_private: stop writing to wmf* constants

https://gerrit.wikimedia.org/r/770102

gerritbot added a comment.Mar 16 2022, 8:05 PM

Change 768254 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate wmfDatacenter(s) to wmgDatacenter(s)

https://gerrit.wikimedia.org/r/768254

Stashbot added a comment.Mar 16 2022, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-16T20:11:24Z] <urbanecm@deploy1002> Synchronized wmf-config/: f649199: Migrate wmfDatacenter(s) to wmgDatacenter(s) (T45956; 1/3) (duration: 00m 50s)

Stashbot added a comment.Mar 16 2022, 8:12 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-16T20:12:14Z] <urbanecm@deploy1002> Synchronized multiversion/: f649199: Migrate wmfDatacenter(s) to wmgDatacenter(s) (T45956; 2/3) (duration: 00m 50s)

Stashbot added a comment.Mar 16 2022, 8:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-16T20:13:04Z] <urbanecm@deploy1002> Synchronized docroot/noc/db.php: f649199: Migrate wmfDatacenter(s) to wmgDatacenter(s) (T45956; 3/3) (duration: 00m 49s)

gerritbot added a comment.Mar 16 2022, 10:01 PM

Change 771469 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to $wmfDatacenter(s)

https://gerrit.wikimedia.org/r/771469

gerritbot added a comment.Mar 21 2022, 8:21 PM

Change 768256 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate away from $wmfDbconfigFromEtcd

https://gerrit.wikimedia.org/r/768256

Stashbot added a comment.Mar 21 2022, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-21T20:28:59Z] <urbanecm@deploy1002> Synchronized wmf-config/etcd.php: 3bcccdc: Migrate away from $wmfDbconfigFromEtcd (T45956; 1/2) (duration: 00m 50s)

Stashbot added a comment.Mar 21 2022, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-21T20:29:50Z] <urbanecm@deploy1002> Synchronized docroot/noc/db.php: 3bcccdc: Migrate away from $wmfDbconfigFromEtcd (T45956; 2/2) (duration: 00m 50s)

gerritbot added a comment.Mar 24 2022, 1:10 PM

Change 771469 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to $wmfDatacenter(s)

https://gerrit.wikimedia.org/r/771469

Stashbot added a comment.Mar 24 2022, 1:15 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T13:15:13Z] <reedy@deploy1002> Synchronized tests/: T45956 (duration: 00m 49s)

Stashbot added a comment.Mar 24 2022, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T13:23:45Z] <reedy@deploy1002> Synchronized multiversion/: T45956 (duration: 00m 50s)

Stashbot added a comment.Mar 24 2022, 1:26 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T13:26:02Z] <reedy@deploy1002> Synchronized wmf-config/CommonSettings.php: T45956 (duration: 00m 49s)

gerritbot added a comment.Mar 24 2022, 5:31 PM

Change 773602 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Use $wmgUseRestbaseVRS in comment

https://gerrit.wikimedia.org/r/773602

gerritbot added a comment.Mar 24 2022, 5:58 PM

Change 773607 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to $wmgAllServices the same value as to $wmfAllServices

https://gerrit.wikimedia.org/r/773607

gerritbot added a comment.Mar 24 2022, 5:58 PM

Change 773608 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Migrate $wmfAllServices to $wmgAllServices

https://gerrit.wikimedia.org/r/773608

gerritbot added a comment.Mar 24 2022, 5:58 PM

Change 773609 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to $wmfAllServices

https://gerrit.wikimedia.org/r/773609

gerritbot added a comment.Mar 24 2022, 8:03 PM

Change 773602 merged by jenkins-bot:

[operations/mediawiki-config@master] Use $wmgUseRestbaseVRS in comment

https://gerrit.wikimedia.org/r/773602

Stashbot added a comment.Mar 24 2022, 8:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T20:08:18Z] <thcipriani@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:773602|Use $wmgUseRestbaseVRS in comment (T45956)]] (duration: 01m 05s)

gerritbot added a comment.Mar 24 2022, 8:19 PM

Change 768255 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to certain $wmf* global variables

https://gerrit.wikimedia.org/r/768255

Stashbot added a comment.Mar 24 2022, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T20:28:30Z] <thcipriani@deploy1002> Synchronized tests: Config: [[gerrit:768255|Stop writing to certain $wmf* global variables (T45956)]] (part I) (duration: 00m 50s)

Stashbot added a comment.Mar 24 2022, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T20:29:58Z] <thcipriani@deploy1002> Synchronized docroot/noc/db.php: Config: [[gerrit:768255|Stop writing to certain $wmf* global variables (T45956)]] (part II) (duration: 00m 51s)

Stashbot added a comment.Mar 24 2022, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T20:31:30Z] <thcipriani@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:768255|Stop writing to certain $wmf* global variables (T45956)]] (part 3) (duration: 00m 55s)

gerritbot added a comment.Mar 24 2022, 8:38 PM

Change 773607 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to $wmgAllServices the same value as to $wmfAllServices

https://gerrit.wikimedia.org/r/773607

Stashbot added a comment.Mar 24 2022, 8:43 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-24T20:43:46Z] <thcipriani@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:773607|Start writing to $wmgAllServices the same value as to $wmfAllServices (T45956)]] (duration: 01m 17s)

gerritbot added a comment.Mar 27 2022, 8:07 PM

Change 774019 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Migrate $wmfServiceConfig to $wmgServiceConfig

https://gerrit.wikimedia.org/r/774019

Zabe removed a project: MediaWiki-extensions-WikimediaMaintenance.Mar 27 2022, 8:23 PM
gerritbot added a comment.Mar 28 2022, 1:49 PM

Change 773608 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate $wmfAllServices to $wmgAllServices

https://gerrit.wikimedia.org/r/773608

Stashbot added a comment.Mar 28 2022, 1:53 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:53:42Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/CirrusSearch-production.php: Config: [[gerrit:773608|Migrate $wmfAllServices to $wmgAllServices (T45956)]] (1/5) (duration: 00m 51s)

Stashbot added a comment.Mar 28 2022, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:54:56Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:773608|Migrate $wmfAllServices to $wmgAllServices (T45956)]] (2/5) (duration: 00m 56s)

Stashbot added a comment.Mar 28 2022, 1:56 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:56:10Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/filebackend.php: Config: [[gerrit:773608|Migrate $wmfAllServices to $wmgAllServices (T45956)]] (3/5) (duration: 00m 51s)

Stashbot added a comment.Mar 28 2022, 1:57 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:57:35Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/CirrusSearch-labs.php: Config: [[gerrit:773608|Migrate $wmfAllServices to $wmgAllServices (T45956)]] (4/5, prod noop) (duration: 01m 07s)

Stashbot added a comment.Mar 28 2022, 1:58 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T13:58:53Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/CommonSettings-labs.php: Config: [[gerrit:773608|Migrate $wmfAllServices to $wmgAllServices (T45956)]] (5/5, prod noop) (duration: 01m 04s)

gerritbot added a comment.Mar 28 2022, 3:20 PM

Change 774497 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to $wmgLocalServices the same value as to $wmfLocalServices

https://gerrit.wikimedia.org/r/774497

gerritbot added a comment.Mar 28 2022, 3:26 PM

Change 774499 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Migrate $wmfLocalServices to $wmgLocalServices

https://gerrit.wikimedia.org/r/774499

gerritbot added a comment.Mar 28 2022, 3:26 PM

Change 774500 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to $wmfLocalServices

https://gerrit.wikimedia.org/r/774500

gerritbot added a comment.Mar 28 2022, 8:19 PM

Change 773609 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to $wmfAllServices

https://gerrit.wikimedia.org/r/773609

Stashbot added a comment.Mar 28 2022, 8:22 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-28T20:22:42Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: dfa963895f39760b647be5507c7f74ec3489cd22: Stop writing to $wmfAllServices (T45956) (duration: 00m 55s)

gerritbot added a comment.Mar 31 2022, 8:06 PM

Change 774019 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate $wmfServiceConfig to $wmgServiceConfig

https://gerrit.wikimedia.org/r/774019

gerritbot added a comment.Mar 31 2022, 8:14 PM

Change 774497 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to $wmgLocalServices the same value as to $wmfLocalServices

https://gerrit.wikimedia.org/r/774497

Stashbot added a comment.Mar 31 2022, 8:16 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T20:16:07Z] <thcipriani@deploy1002> Synchronized wmf-config/PhpAutoPrepend.php: Config: [[gerrit:774019|Migrate $wmfServiceConfig to $wmgServiceConfig (T45956)]] (duration: 00m 50s)

Stashbot added a comment.Mar 31 2022, 8:22 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T20:22:38Z] <thcipriani@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:774497|Start writing to $wmgLocalServices the same value as to $wmfLocalServices (T45956)]] (duration: 00m 50s)

gerritbot added a comment.Mar 31 2022, 8:24 PM

Change 774499 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate $wmfLocalServices to $wmgLocalServices

https://gerrit.wikimedia.org/r/774499

Stashbot added a comment.Mar 31 2022, 8:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T20:29:44Z] <thcipriani@deploy1002> Synchronized wmf-config: Config: [[gerrit:774499|Migrate $wmfLocalServices to $wmgLocalServices (T45956)]] (duration: 00m 51s)

gerritbot added a comment.Mar 31 2022, 8:32 PM

Change 774500 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to $wmfLocalServices

https://gerrit.wikimedia.org/r/774500

Stashbot added a comment.Mar 31 2022, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-31T20:36:58Z] <thcipriani@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:774500|Stop writing to $wmfLocalServices (T45956)]] (duration: 00m 50s)

gerritbot added a comment.Apr 1 2022, 9:31 PM

Change 776253 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] tests: rename $wmfConfigDir to $configDir

https://gerrit.wikimedia.org/r/776253

gerritbot added a comment.Apr 1 2022, 9:38 PM

Change 776254 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to $wmgUsingKubernetes the same value as to $wmfUsingKubernetes

https://gerrit.wikimedia.org/r/776254

gerritbot added a comment.Apr 1 2022, 9:38 PM

Change 776255 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Migrate $wmfUsingKubernetes to $wmgUsingKubernetes

https://gerrit.wikimedia.org/r/776255

gerritbot added a comment.Apr 1 2022, 9:38 PM

Change 776256 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to $wmfUsingKubernetes

https://gerrit.wikimedia.org/r/776256

gerritbot added a comment.Apr 1 2022, 9:46 PM

Change 776257 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to $wmgUdp2logDest the same value as to $wmfUdp2logDest

https://gerrit.wikimedia.org/r/776257

gerritbot added a comment.Apr 1 2022, 9:46 PM

Change 776258 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Migrate $wmfUdp2logDest to $wmgUdp2logDest

https://gerrit.wikimedia.org/r/776258

gerritbot added a comment.Apr 1 2022, 9:46 PM

Change 776259 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to $wmfUdp2logDest

https://gerrit.wikimedia.org/r/776259

gerritbot added a comment.Apr 5 2022, 1:18 PM

Change 776257 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to $wmgUdp2logDest the same value as to $wmfUdp2logDest

https://gerrit.wikimedia.org/r/776257

Stashbot added a comment.Apr 5 2022, 1:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-05T13:20:55Z] <taavi@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:776257|Start writing to $wmgUdp2logDest the same value as to $wmfUdp2logDest (T45956)]] (duration: 00m 54s)

gerritbot added a comment.Apr 5 2022, 8:34 PM

Change 776253 merged by jenkins-bot:

[operations/mediawiki-config@master] tests: rename $wmfConfigDir to $configDir

https://gerrit.wikimedia.org/r/776253

gerritbot added a comment.Apr 6 2022, 1:14 PM

Change 776254 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to $wmgUsingKubernetes the same value as to $wmfUsingKubernetes

https://gerrit.wikimedia.org/r/776254

Stashbot added a comment.Apr 6 2022, 1:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-06T13:20:50Z] <kartik@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:776254|Start writing to $wmgUsingKubernetes the same value as to $wmfUsingKubernetes (T45956)]] (duration: 00m 55s)

gerritbot added a comment.Apr 10 2022, 2:34 PM

Change 778667 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Migrate $wmfConfigDir to $wmgConfigDir

https://gerrit.wikimedia.org/r/778667

gerritbot added a comment.Apr 11 2022, 8:04 PM

Change 776255 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate $wmfUsingKubernetes to $wmgUsingKubernetes

https://gerrit.wikimedia.org/r/776255

Stashbot added a comment.Apr 11 2022, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-11T20:11:11Z] <urbanecm@deploy1002> Synchronized wmf-config/: d4ff32f: Migrate $wmfUsingKubernetes to $wmgUsingKubernetes (T45956) (duration: 00m 53s)

gerritbot added a comment.Apr 11 2022, 8:12 PM

Change 776256 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to $wmfUsingKubernetes

https://gerrit.wikimedia.org/r/776256

Stashbot added a comment.Apr 11 2022, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-11T20:15:31Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: 8455fa0: Stop writing to $wmfUsingKubernetes (T45956) (duration: 00m 51s)

gerritbot added a comment.Apr 12 2022, 1:09 PM

Change 778667 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate $wmfConfigDir to $configDir

https://gerrit.wikimedia.org/r/778667

Stashbot added a comment.Apr 12 2022, 1:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-12T13:13:30Z] <urbanecm@deploy1002> Synchronized multiversion/buildConfigCache.php: 8b74b085704a75bd52d490fecfa8a8996f17ce89: Migrate $wmfConfigDir to $configDir (T45956) (duration: 00m 51s)

Volans subscribed.Apr 13 2022, 9:44 AM

Will the work on this task also change the key wmfMasterDatacenter in siteinfo's ['query']['general']['wmf-config']?
If so please ping me when that will happen as I have to adjust spicerack accordingly.

Reedy added a comment.Apr 13 2022, 12:39 PM

It could, but it doesn't have to; it's this block in CommonSettings.php:

// Add some useful config data to query=siteinfo
$wgHooks['APIQuerySiteInfoGeneralInfo'][] = static function ( $module, &$data ) {
	global $wmgMasterDatacenter;
	global $wmgEtcdLastModifiedIndex;
	global $wmgCirrusSearchDefaultCluster;
	global $wgCirrusSearchDefaultCluster;
	$data['wmf-config'] = [
		'wmfMasterDatacenter' => $wmgMasterDatacenter,
		'wmfEtcdLastModifiedIndex' => $wmgEtcdLastModifiedIndex,
		'wmgCirrusSearchDefaultCluster' => $wmgCirrusSearchDefaultCluster,
		'wgCirrusSearchDefaultCluster' => $wgCirrusSearchDefaultCluster,
	];
};

The globals can be renamed, the API key doesn't have to be. Like already has seemingly been done with the wmfEtcdLastModifiedIndex has stayed the same, but the variable reference updated to go with the rename.

Zabe added a comment.Apr 13 2022, 12:51 PM

I do not plan to rename the API keys, as that is not backwards-compatible.

Volans added a comment.Apr 13 2022, 12:52 PM

Perfect, thanks for clarifying.

gerritbot added a comment.Apr 13 2022, 1:25 PM

Change 776258 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate $wmfUdp2logDest to $wmgUdp2logDest

https://gerrit.wikimedia.org/r/776258

Stashbot added a comment.Apr 13 2022, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-13T13:27:00Z] <reedy@deploy1002> Synchronized wmf-config/: Migrate $wmfUdp2logDest to $wmgUdp2logDest - T45956 (duration: 00m 55s)

Volans unsubscribed.Apr 13 2022, 1:27 PM
gerritbot added a comment.Apr 13 2022, 1:48 PM

Change 779856 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Migrate $wmfSwiftConfig to $wmgSwiftConfig

https://gerrit.wikimedia.org/r/779856

gerritbot added a comment.Apr 14 2022, 8:04 PM

Change 776259 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to $wmfUdp2logDest

https://gerrit.wikimedia.org/r/776259

Stashbot added a comment.Apr 14 2022, 8:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-14T20:08:29Z] <brennen@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:776259|Stop writing to $wmfUdp2logDest (T45956)]] (duration: 00m 48s)

gerritbot added a comment.Apr 14 2022, 8:15 PM

Change 768259 merged by jenkins-bot:

[operations/mediawiki-config@master] Write the same value to wmgSwiftConfig as to wmfSwiftConfig

https://gerrit.wikimedia.org/r/768259

Stashbot added a comment.Apr 14 2022, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-14T20:19:37Z] <cjming@deploy1002> Synchronized private/readme.php: Config: [[gerrit:768259|Write the same value to wmgSwiftConfig as to wmfSwiftConfig (T45956)]] (duration: 00m 48s)

gerritbot added a comment.Apr 14 2022, 8:22 PM

Change 779856 merged by jenkins-bot:

[operations/mediawiki-config@master] Migrate $wmfSwiftConfig to $wmgSwiftConfig

https://gerrit.wikimedia.org/r/779856

Stashbot added a comment.Apr 14 2022, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2022-04-14T20:26:03Z] <thcipriani@deploy1002> Synchronized wmf-config/filebackend.php: Config: [[gerrit:779856|Migrate $wmfSwiftConfig to $wmgSwiftConfig (T45956)]] (duration: 00m 49s)

gerritbot added a comment.Apr 14 2022, 9:36 PM

Change 781058 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to $wmfSwiftConfig

https://gerrit.wikimedia.org/r/781058

gerritbot added a comment.Apr 25 2022, 12:58 PM

Change 781058 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to $wmfSwiftConfig

https://gerrit.wikimedia.org/r/781058

Zabe closed this task as Resolved.Apr 29 2022, 11:42 AM
Zabe removed a project: Patch-For-Review.

\o/

DannyS712 added a comment.Jun 6 2022, 1:29 AM

Is there also a task for the various global functions wmf*() -> wmg*() ?

Legoktm subscribed.Jun 6 2022, 2:18 AM
In T45956#7981795, @DannyS712 wrote:

Is there also a task for the various global functions wmf*() -> wmg*() ?

the g is for global and f is for function...

DannyS712 added a comment.Jun 6 2022, 2:45 AM
In T45956#7981817, @Legoktm wrote:
In T45956#7981795, @DannyS712 wrote:

Is there also a task for the various global functions wmf*() -> wmg*() ?

the g is for global and f is for function...

Oh, duh, sorry

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL