Page MenuHomePhabricator

JavaScript error in ULS
Closed, InvalidPublic

Description

Apparently also breaking some local JS, including LangSelect for some people (and that's quite an important one).
Quoting from the URL.


<p>Fecha y hora: 15/01/2013 21:12:43</p>
<p>'''Error: TypeError: previousLanguages.push is not a function'''</p>
<p>Archivo de origen: https://bits.wikimedia.org/meta.wikimedia.org/load.php?debug=false&lang=en&modules=ext.centralNotice.bannerController%7Cext.translate%7Cext.uls.displaysettings%2Cgeoclient%2Cime%2Cinit%2Cinputsettings%2Clanguagesettings%2Cpreferences%2Cwebfonts%7Cext.uls.webfonts.repository%7Cjquery.byteLength%2CbyteLimit%2Cclient%2Ccookie%2Ci18n%2Cime%2CjStorage%2Cjson%2CmwExtension%2CtextSelection%2Ctipsy%2Culs%2Cwebfonts%7Cmediawiki.Uri%2Capi%2Cnotify%2Cuser%2Cutil%7Cmediawiki.action.edit%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.page.startup&skin=monobook&version=20130115T091957Z&*</p>
<p>Línea: 27</p>

Which is:

previousLanguages.push(currentLang);mw.uls.setPreviousLanguages(previousLanguages);$ulsTrigger.tipsy({gravity:'n',delayOut:3000,html:true,fade:true,trigger:'manual',title:function(){var link;link=$('<a>').text($.uls.data.getAutonym(previousLang)).attr({href:'#','class':'uls-prevlang-link',lang:previousLang,dir:$.uls.data.getDir(previousLang)});link=$('<div>').html(link).html();return $.i18n('ext-uls-undo-language-tooltip-text',link);}});function showTipsy(timeout){var tipsyTimer=0;$ulsTrigger.tipsy('show');$('.tipsy').on('mouseover',function(){window.clearTimeout(tipsyTimer);});$('.tipsy').on('mouseout',function(){tipsyTimer=window.setTimeout(function(){hideTipsy();},timeout);});$('a.uls-prevlang-link').on('click',function(){mw.uls.changeLanguage($(this).attr('lang'));});tipsyTimer=window.setTimeout(function(){hideTipsy();},timeout);}function hideTipsy(){$ulsTrigger.tipsy('hide');}showTipsy(6000);$ulsTrigger.on('mouseover',function(){if(!$ulsTrigger.data('uls').shown){showTipsy(3000);}


Version: master
Severity: normal
URL: https://meta.wikimedia.org/w/index.php?diff=5051434&oldid=5051328&rcid=3834461

Details

Reference
bz44013

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:17 AM
bzimport set Reference to bz44013.

Nemo: What is LangSelect? Where does it live?

I'm having trouble reproducing this problem. Can we have the following information, please?

  1. Operating system
  2. Browser
  3. Browser version
  4. Steps to reproduce

Marco Aurelio, can you please add details?

(In reply to comment #3)

I'm having trouble reproducing this problem. Can we have the following
information, please?

  1. Operating system
  2. Browser
  3. Browser version
  4. Steps to reproduce

What I got so far:

  1. Windows, if I remember correctly.
  2. Firefox

3, 4: ?

Hi,

(In reply to comment #3)

I'm having trouble reproducing this problem. Can we have the following
information, please?

  1. Operating system
  2. Browser
  3. Browser version
  4. Steps to reproduce

I don't really feel confortable giving all that information here. Feel free to email me and I'll provide it.

As for the steps to reproduce: really none, just logged-in today, saw that ULS was deployed at Meta; visited some pages and noticed that multilingual templates were not working anymore while logged-in (logged-out they worked fine). The data Nemo provides above in comment 0 is from the error console of my browser. I've not modified any JS/CSS personal files either.

I must also say that as of today some useful scripts that I have in my common.js file at Meta-Wiki stopped working too.

Best regards & thanks for taking a look at this (and to Nemo for creating this ticket).

Apart from the pasted error, we are not familiar with the scripts running in meta and it is very hard for us to know what is expected or unexpected behavior for them. Thus "they are not working" is not useful to us. Either that has to be described in high detail or you must ask the script authors to investigate first.

Marco asked to email privately, so I did. There MAY be a ULS issue here that I am missing, but I need more info.

It works for me, I suspect of some issue of a not-correctly-purged script.

Cannot reproduce either when playing around with ULS on meta, plus currently missing enough information to reproduce.

Closing as invalid for now. Please feel free to reopen when actionable information is added.