Page MenuHomePhabricator

PageTriage: the review action is incompatible with the presence of Pending Changes
Closed, ResolvedPublic

Description

What it says on the tin; if a page is under Pending Changes protection, it cannot be reviewed.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44073

Details

Reference
bz44065

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:21 AM
bzimport added a project: PageTriage.
bzimport set Reference to bz44065.
  • Bug 44073 has been marked as a duplicate of this bug. ***

Specifically, the Curation Toolbar does not display on pages under Pending Changes. There's no JS error, so I'm not sure what is actually causing this.

Some steps to reproduce this would be helpful.

(In reply to comment #3)

Some steps to reproduce this would be helpful.

Uhm. To replicate "if a page is under Pending Changes protection, it
cannot be reviewed."?

Go to a page under pending changes protection that is in the new pages feed. Try to review it.

Go to a page under pending changes protection that is in the new pages feed.
Try to review it.

Not what I meant, I don't have permissions to review on wikipedia. I meant how to protect under Pending Changes in my local wiki (I don't know if that is a template or whatever).

Not what I meant, I don't have permissions to review on wikipedia. I meant
how
to protect under Pending Changes in my local wiki (I don't know if that is a
template or whatever).

Pending Changes is [[mw:Extension:FlaggedRevs]]. Install that and "protect" an article with it. enwikip probably has customized it though.

I 'think' the potential problem is - FlaggedRevs doesn't allow patrolling on any reviewable page by hooking into user permissions (evil) and Page Triage finds that the user can't review if he doesn't have patrolling rights (which apparently he doesn't have) and doesn't show the curation toolbar.

comment from FlaggedRevs.hooks.php

Don't let users patrol reviewable pages (where reviewed <=> patrolled)

comment from PageTriage.hooks.php
// Don't show anything for user with no patrol right

Again I think this what is happening.

No, just the first problem. 'review' in a PageTriage context is distinct from 'review' in a FlaggedRevs context - it's the same as patrol. And the userright for patrol is, well, autoconfirmed.

So the problem would appear to be that FlaggedRevs refuses to class the page as patrollable and so PageTriage dies. That's it. It's just FlaggedRevs that needs a tweak.

(In reply to comment #8)

It's just FlaggedRevs that needs a tweak.

Then should the bug be moved to FlaggedRevs?

If you really want, but frankly I worry it'll go over there, die a lonely death with no active maintenance, and the result will be that a (fully deployed) extension doesn't function in the presence of a rarely deployed one.

Change merged, hopefully fixed.