swalling wrote:

Mockup

Attached:

swalling wrote:

To be clearer: the behavior of the checkbox is if it is checked, it removes the cookie and ends the tour completely.

It seems a little odd to have a checkbox alone end the whole tour (which includes closing the current step).

Normally I expect a checkbox to provide additional information, but still have to click some sort of button. An example from another area:

• Checkbox says "Email me updates"
• Button says "Signup"

The checkbox only takes effect if they signup.

Also, "hide these" could easily be misinterpreted as disabling all GuidedTours. We'll probably want to do that as a separate feature at some point (likely as a preference, but possibly also exposed elsewhere), but we don't want to confuse people.

swalling wrote:

(In reply to comment #3)

It seems a little odd to have a checkbox alone end the whole tour (which
includes closing the current step).

Normally I expect a checkbox to provide additional information, but still
have
to click some sort of button. An example from another area:

• Checkbox says "Email me updates"
• Button says "Signup"

The checkbox only takes effect if they signup.

I filed this as a separate bug, but the feature request is in the context of what Munaf was suggesting, where the action button takes users to the next step EXCEPT if they check the hide box. Checking the box alone wouldn't dismiss the tour alone, without a confirmation.

Also, "hide these" could easily be misinterpreted as disabling all
GuidedTours.
We'll probably want to do that as a separate feature at some point (likely
as
a preference, but possibly also exposed elsewhere), but we don't want to
confuse people.

That confusion is worth reducing the text, and adding a preference in the future is a great idea.

However, Munaf suggested 'Okay'. 'Next' is more clearly stating there will be a next step, so if we choose this option, I would prefer 'Okay'.

Can't we just have the checkbox say "end tour"? That's even shorter than "hide these".

swalling wrote:

(In reply to comment #5)

However, Munaf suggested 'Okay'. 'Next' is more clearly stating there will
be
a next step, so if we choose this option, I would prefer 'Okay'.

Can't we just have the checkbox say "end tour"? That's even shorter than
"hide
these".

We can dicker about the text later. Let's get the elements to describe in place.

Okay, the initial version of this is done at https://gerrit.wikimedia.org/r/#/c/44752/ .

It handles the basics:

1. Always shows checkbox.
2. If you check it and click okay, it ends the tour.
3. Otherwise, it does a user-defined action (the only one that can occupy 'Okay' currently is "next" for going to next step). If there is no user-defined action, it closes the step without ending the tour.

There are a couple edge cases I didn't attempt to address:

1. What happens if they check it and click a button besides Okay (currently the checkbox is ignored).
2. At the start of the tour, should we still just show Okay, also a "Start Tour" button, or maybe something else?

What about "Start Tour" and "No Thanks" (with no checkbox)?

3. What do we do at the end of the tour? Do we keep End Tour? If so, do we have okay and the checkbox in addition?

It seems simpler to just have an End Tour button here (with no need for a checkbox).

It's ready for testing on piramido.

swalling wrote:

Looks good to me.

Edge cases above still need to be defined here.

• Bug 44323 has been marked as a duplicate of this bug. ***

swalling wrote:

(In reply to comment #7)

There are a couple edge cases I didn't attempt to address:

1. What happens if they check it and click a button besides Okay (currently

the
checkbox is ignored).

We could leave it like that, but requiring the Okay click is not the most helpful or obvious thing for an annoyed user. Let's do this: IF checkbox selected, then all close actions end the tour, instead of just close. This works at any point.

2. At the start of the tour, should we still just show Okay, also a "Start

Tour" button, or maybe something else?

Just the Okay button. Since the correct behavior of "Okay" is to progress the user to the next step, this functions as a start tour action implicitly. Having two action buttons like that is confusing.

What about "Start Tour" and "No Thanks" (with no checkbox)?

Let's keep consistency from beginning to end, not have special start/end tour actions that the user has to stop and think about.

3. What do we do at the end of the tour? Do we keep End Tour? If so, do we

have okay and the checkbox in addition?

Let's just keep Okay, and if it's the final step, it ends the tour.

For the end of the tour, should there be a checkbox?

swalling wrote:

(In reply to comment #12)

For the end of the tour, should there be a checkbox?

Let's just leave it there.

Merged. All of the edge cases are addressed as specified.

Dan Andreescu suggested that when you click the checkbox, the button text could change (e.g. Okay/End tour). It's worth pondering for later.