Maniphest T46130

Use real (logic-less) templates to generate HTML
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Jan 19 2013, 12:08 AM

Tags

Referenced Files

None

Subscribers

Description

Author: jgonera

Description:
We could really use templates to untangle SkinMobile.php. Since we'll be using Mustache[1] templates in JavaScript (or specifically the Hogan[2] implementation), we could also consider using them on the server side.

Logic-less templates enforce separation between logic and presentation because you simply can not write any code inside them. Separate files for HTML and PHP code for the win!

[1] http://mustache.github.com/
[2] http://twitter.github.com/hogan.js/

Version: unspecified
Severity: enhancement

Details

Reference: bz44130

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:26 AM

• bzimport added a project: Don't use – MobileFrontend-Hygiene.

• bzimport set Reference to bz44130.

• bzimport created this task.Jan 19 2013, 12:08 AM

I've experimented with this and it's beautiful:
https://github.com/jdlrobson/Minerva/blob/evenmorevanilla/Minerva.php#L72

We should probably drive work on the skin and then create a RFC to see how people feel about bringing in an external library..

mgrover wrote:

Assigned Mingle Ticket https://mingle.corp.wikimedia.org/projects/mobile/cards/719

Related URL: https://gerrit.wikimedia.org/r/69756 (Gerrit Change I742eb3587f3736a9c1932bc86ee59c4fe26ca434)

We will be exploring this as part of the UI standardisation project (templating in core)

Jdforrester-WMF edited projects, added Technical-Debt, MobileFrontend-General-or-Unknown; removed Don't use – MobileFrontend-Hygiene.Dec 8 2014, 9:42 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed MobileFrontend-General-or-Unknown.Dec 10 2014, 12:08 AM

Jdlrobson set Security to None.

Jdlrobson moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog board.Dec 10 2014, 12:15 AM

This is done now! Thanks @kaldari

• Phabricator_maintenance moved this task from 2016-17 Q4 to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:20 AM