Page MenuHomePhabricator
Create Task
Maniphest T46161

IPv6 at some places lower case and at other places in upper case
Open, LowPublic
Actions

Description

When a IPv6 is making a edit, the link text on the Watchlist is in lower case, but the link to Special:Contributions has the ipv6 in upper case in it.

That is confusing. It is possible to have the ipv6 showing all the same on each place? I have no problem, when the user page of a ipv6 is under the lower case name, that looks better, than the upper cases.

See Also:
https://github.com/azatoth/twinkle/issues/145
T56219: Old short/abbreviated IPv6 addresses in Changelog should be turned into long format
T41017: IPv6 addresses should use lowercase hexadecimal digits

Details

Reference
bz44161

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:28 AM
• bzimport added projects: MediaWiki-Special-pages, IPv6.
• bzimport set Reference to bz44161.
• bzimport added a subscriber: Unknown Object (MLST).
duplicatebug created this task.Jan 19 2013, 7:19 PM
Aklapper added a comment.Jan 21 2013, 7:23 AM

Not sure if this is a dup or a dep of bug 39017, hence marking as dep only.

TTO added a comment.Mar 17 2013, 9:57 AM

This is causing problems for Twinkle on enwiki (which is forced to lightly screen-scrape the loaded page in order to find out what the user is looking at).

Either IP::prettifyIP [1] should be used everywhere, or nowhere. According to [2] this function is only called from one place in the code.

IMHO it is too difficult to change over to sanitized IP addresses throughout the entire codebase, so I say we kill prettifyIP (or at least remove its sole invocation [3]).

[1] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/IP.php;h=72b9a52c8123d863bdbe44161c9760af778b496e;hb=HEAD#l195
[2] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git&a=search&h=HEAD&st=grep&s=prettifyIP
[3] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/Linker.php;h=972adfceabbe818e97d192c142440263a11b6af1;hb=HEAD#l1085

Jasper added a comment.May 12 2013, 7:28 AM

It is important to note that if MediaWiki completely converted to the proper standard, thousands of IP talk pages and many more database entries would have to be updated.

I'm fine any way for prettifyIP, but others do find collapsed addresses more convenient.

gerritbot added a comment.Oct 28 2013, 4:18 AM

Change 92263 had a related patch set uploaded by TTO:
Stop using prettifyIP for user links

https://gerrit.wikimedia.org/r/92263

gerritbot added a comment.Nov 19 2014, 10:45 AM

Change 92263 abandoned by TTO:
Stop using prettifyIP for user links

Reason:
I don't think this is ever going to get anywhere.

https://gerrit.wikimedia.org/r/92263

duplicatebug unsubscribed.Dec 13 2014, 4:37 PM
matej_suchanek removed a project: Patch-For-Review.Apr 2 2016, 3:39 PM
matej_suchanek updated the task description. (Show Details)
matej_suchanek removed a subscriber: • wikibugs-l-list.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2016, 3:39 PM
matej_suchanek added subtasks: T122804: Display of IPv6 usernames is inconsistent: lowercase vs. uppercase, T147031: Automatic undo/revert edit summary should use consistent IPv6 formatting.Aug 2 2018, 12:48 PM
matej_suchanek mentioned this in T41017: IPv6 addresses should use lowercase hexadecimal digits.
Amorymeltzer subscribed.Apr 15 2019, 9:18 PM
Aklapper mentioned this in T56219: Old short/abbreviated IPv6 addresses in Changelog should be turned into long format.Aug 11 2019, 9:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL