Page MenuHomePhabricator

$wgDBuser not set explicitly in wmf-config but relies on DefaultSettings
Closed, ResolvedPublic

Description

The DB user name on the WMF cluster is 'wikiuser'. This isn't set anywhere in wmf-config, but it just so happens to be the software default in includes/DefaultSettings.php . We should set this value explicitly in wmf-config, otherwise the site would break completely if the software default ever changes.


Version: wmf-deployment
Severity: normal

Details

Reference
bz44251

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:33 AM
bzimport set Reference to bz44251.

(In reply to comment #0)

We should set this value explicitly in
wmf-config, otherwise the site would break completely if the software default
ever changes.

Why would we ever change that?

(In reply to comment #2)

Why would we ever change that?

I guess Roan reason is "better safe than sorry".

Thanks for your review, merged and deployed!

(In reply to comment #3)

(In reply to comment #2)

Why would we ever change that?

I guess Roan reason is "better safe than sorry".

Tinfoil hats for everyone!

Thanks for your review, merged and deployed!

Anytime :)