Page MenuHomePhabricator

The Create Account page fails in IE when E3Experiments is enabled
Closed, ResolvedPublic

Description

We've received multiple complaints (via OTRS) about the account creation page failing on the English Wikipedia. Insofar as I can tell, it's related to Internet Explorer.

For reference:
[[Ticket:2013012310013069]]
[[Ticket:2013012410001052]]


Version: unspecified
Severity: normal

Details

Reference
bz44298

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:36 AM
bzimport set Reference to bz44298.

Confirmed with IE 8 on Windows XP. A JavaScript error also appears. With &debug=true the error appears at extensions/EventLogging/modules/ext.eventLogging.core.js line 149:

if ( desc[ 'enum' ] && desc[ 'enum' ].indexOf( val ) === -1 ) {

Message: Object doesn't support this property or method

I see what the issue is. It should be using $.inArray, which is cross-browser.

Confirmed that the problem is fixed in IE8. Updated the bug summary so that this report can stay open.

(In reply to comment #4)

Confirmed that the problem is fixed in IE8. Updated the bug summary so that
this report can stay open.

Thanks.

All changes merged.

This can be deployed with a sync-file when Tim gives the go ahead.

I've reverted the fix in wmf/1.21wmf7 (https://gerrit.wikimedia.org/r/#/c/45560/) - I needed to scap and this change was laying around. Didn't feel comfortable pushing it out since the last comment on this thread was 'This can be deployed with a sync-file when Tim gives the go ahead' - Tim nor anyone else I know who works on EventLogging is not currently around.

[moving from MediaWiki extensions to Analytics product - see bug 61946]