Page MenuHomePhabricator

updateSpecialPages is run twice on small wikis
Closed, ResolvedPublic

Description

I'm not quite sure why, but special pages are updated on small wikis twice - A run over all.dblist, and then later a run over small.dblist

In it's present state, the small only cronjob is useless. I'll probably just disable it for now

class misc::maintenance::update_special_pages {
cron {

		update_special_pages:
			command => "flock -n /var/lock/update-special-pages /usr/local/bin/update-special-pages > /home/wikipedia/logs/norotate/updateSpecialPages.log 2>&1",
			user => "apache",
			monthday => "*/3",
			hour => 5,
			minute => 0,
			ensure => present;
		update_special_pages_small:
			command => "flock -n /var/lock/update-special-pages-small /usr/local/bin/update-special-pages-small > /home/wikipedia/logs/norotate/updateSpecialPages-small.log 2>&1",
			user => "apache",
			monthday => "*/3",
			hour => 4,
			minute => 0,
			ensure => present;

}

file {

		"/usr/local/bin/update-special-pages":
			source => "puppet:///files/misc/scripts/update-special-pages",
			owner => apache,
			group => wikidev,
			mode => 0755,
			ensure => present;
		"/usr/local/bin/update-special-pages-small":
			source => "puppet:///files/misc/scripts/update-special-pages-small",
			owner => apache,
			group => wikidev,
			mode => 0755,
			ensure => present;

}
}

reedy@fenari:/home/wikipedia/logs/norotate$ cat /usr/local/bin/update-special-pages
#!/bin/bash

cd /home/wikipedia/common/multiversion
for db in </home/wikipedia/common/all.dblist; do

echo $db
php MWScript.php updateSpecialPages.php $db
echo
echo

done
reedy@fenari:/home/wikipedia/logs/norotate$ cat /usr/local/bin/update-special-pages-small
#!/bin/bash

cd /home/wikipedia/common/multiversion
for db in </home/wikipedia/common/small.dblist; do

echo $db
php MWScript.php updateSpecialPages.php $db
echo
echo

done


Version: wmf-deployment
Severity: trivial
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53227

Details

Reference
bz44349

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:39 AM
bzimport set Reference to bz44349.
bzimport added a subscriber: Unknown Object (MLST).

Patch got merged today, closing as FIXED.