Page MenuHomePhabricator
Create Task
Maniphest T46567

phpcs-HEAD should skip if there is no file to process
Closed, ResolvedPublic
Actions

Description

"You must supply at least one file or directory to process"

https://integration.mediawiki.org/ci/job/mediawiki-core-phpcs-HEAD/937/console

Version: unspecified
Severity: major

Details

Reference
bz44567

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:27 AM
• bzimport added a project: Continuous-Integration-Infrastructure.
• bzimport set Reference to bz44567.
• Mattflaschen-WMF created this task.Feb 1 2013, 1:04 AM
• demon added a comment.Feb 1 2013, 1:09 AM

Not a Git/Gerrit bug, rather an issue with Jenkins. Moved to Testing Infrastructure.

hashar added a comment.Feb 1 2013, 10:10 AM

phpcs fails on JS-only changes , which is due to it being passed an empty fileset.

Assigning to myself, I need to tweak out the phpcs-HEAD macro or just skip the entire build whenever there is no PHP files altered.

hashar added a comment.Feb 8 2013, 10:06 AM
  • Bug 44778 has been marked as a duplicate of this bug. ***
duplicatebug added a comment.Feb 10 2013, 10:51 AM
  • Bug 44842 has been marked as a duplicate of this bug. ***
hashar added a comment.Feb 11 2013, 1:48 PM

Hacked with https://gerrit.wikimedia.org/r/48450

hashar added a comment.Feb 11 2013, 1:53 PM

According to my tests, the change above fixed the issue.

hashar added a comment.Feb 11 2013, 1:56 PM

I have launched a reconfiguration of all phpcs-HEAD jobs.

hashar added a comment.Feb 18 2013, 8:27 AM

We turned the original blacklisting of css/js to a whitelist of php/php5/inc/sample with change
https://gerrit.wikimedia.org/r/#/c/49618/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL