Page MenuHomePhabricator

Remove unnecessary entries from $wgMetaNamespaceTalk and $wgMetaNamespace
Closed, ResolvedPublic

Description

Where == str_replace( '$1', $wgMetaNamespace, $namespaceNames[NS_PROJECT_TALK] ) === $wgMetaNamespaceTalk, remove the entry in $wgMetaNamespaceTalk

In most/all cases, these should match, and hence, the explicit entry is unneeded.

Similar can be also said for $wgMetaNamespace, which if it's the same as $wgSitename, it isn't necessary.

/**

  • Name of the project namespace. If left set to false, $wgSitename will be
  • used instead. */

$wgMetaNamespace = false;


Version: wmf-deployment
Severity: enhancement

Details

Reference
bz44629

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:32 AM
bzimport set Reference to bz44629.

I'm re-taking the licked cookie and will submit a patch in a minute.

Change 95796 had a related patch set uploaded by Odder:
(bug 44629) Clean up $wgSitename, $wgMetaNamespace etc.

https://gerrit.wikimedia.org/r/95796

Change 95796 merged by jenkins-bot:
(bug 44629) Clean up $wgMetaNamespace, $wgMetaNamespaceTalk

https://gerrit.wikimedia.org/r/95796