Page MenuHomePhabricator

Current version being displayed as old revision
Closed, ResolvedPublic

Description

When viewing an old revision of a page, all of the current properties are displayed, instead of whatever properties the item had during that revision.


Version: unspecified
Severity: major

Details

Reference
bz44661

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:34 AM
bzimport set Reference to bz44661.
bzimport added a subscriber: Unknown Object (MLST).

This is because the entities serialized as 'wbUsedEntities' for the frontend are the current for some reason. Without JavaScript enabled, the right statements will be displayed.

I've already noticed a while ago while debugging that the whole EntityView logic is called twice, also EntityView::registerJsConfigVars() is running twice. Perhaps this is somehow related.

I was wrong about the code running twice, but the EntityView::registerJsConfigVars() is simply getting called with the wrong EntityContent (the current one) given.

For future reference, it was gerrit change #48612 that fixed this.

Verified in Wikidata demo sprint 32

Verified in Wikidata demo sprint 34

It seems like this has been reintroduced. See https://www.wikidata.org/w/index.php?title=Q192925&oldid=6198828 . It flashes the correct version (without labels). Then it pulls in later statements through AJAX.

Related URL: https://gerrit.wikimedia.org/r/60868 (Gerrit Change I906214322ee6dcb32d397e110d2f097f098cc253)

Related URL: https://gerrit.wikimedia.org/r/60884 (Gerrit Change I906214322ee6dcb32d397e110d2f097f098cc253)