GlobalBlocking right now is hardcoded to not allow anything higher than /16, and has no limits for IPv6. It should use $wgBlockCIDRLimit instead.
Description
Description
Details
Details
- Reference
- bz44836
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Allow to set a limit on global blocks on IP ranges | mediawiki/extensions/GlobalBlocking | master | +30 -11 |
Related Objects
Related Objects
Event Timeline
Comment Actions
I would prefer, for the purposes of flexibility, for the two to be separate configuration variables so we have, say, a $wgGlobalBlockCIDRLimit.
Comment Actions
Change 202776 had a related patch set uploaded (by Glaisher):
Allow to set a limit on global blocks on IP ranges
Comment Actions
Change 202776 abandoned by Glaisher:
Allow to set a limit on global blocks on IP ranges
Reason:
Per my comment earlier - needs extra work.
Comment Actions
From https://gerrit.wikimedia.org/r/#/c/321429/:
To allow for message reuse, this mostly copies the CIDR-handling logic
from ApiQueryBlocks into ApiQueryGlobalBlocks, which has the side effect
of making it actually work for IPv6. Too much refactoring of the rest of
the code would be needed to properly solve T46836 for me to do right
now, though.
Comment Actions
Change 561314 had a related patch set uploaded (by Jasper Deng; owner: Jasper Deng):
[mediawiki/extensions/GlobalBlocking@master] Configurable CIDR rangeblock limits (https://phabricator.wikimedia.org/T46836)
Comment Actions
Change 561314 had a related patch set uploaded (by Gergő Tisza; owner: Jasper Deng):
[mediawiki/extensions/GlobalBlocking@master] Configurable CIDR rangeblock limits