Page MenuHomePhabricator
Create Task
Maniphest T46850

files from UIDGenerator not deleted after test run
Closed, ResolvedPublic
Actions

Description

Running phpunit leaves the following files in the tmp dir:

mw-UIDGenerator-UID-88
mw-UIDGenerator-UID-128
mw-UIDGenerator-UID-nodeid

Should be deleted automatically by UIDGenerator or the test

Version: 1.21.x
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53791

Details

Reference
bz44850

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:17 AM
• bzimport added projects: MediaWiki-Core-Tests, good first task.
• bzimport set Reference to bz44850.
• bzimport added a subscriber: Unknown Object (MLST).
duplicatebug created this task.Feb 10 2013, 3:00 PM
• Spage added a comment.Sep 5 2013, 5:37 AM

The same thing can happen after running maintenance/update.php, see bug 53791.

bd808 added a comment.Mar 27 2014, 8:43 PM

Leaving the files on disk seems to be intended behavior of the UIDGenerator class. It uses these files to store counter state and as an inter-process lock when creating timestamp based UUID variants.

Adding a cleanup to the test should be possible.

gerritbot added a comment.Mar 27 2014, 10:35 PM

Change 121548 had a related patch set uploaded by BryanDavis:
Delete UIDGenerator cache files after unit tests

https://gerrit.wikimedia.org/r/121548

gerritbot added a comment.Apr 7 2014, 11:09 PM

Change 121548 merged by jenkins-bot:
Delete UIDGenerator cache files after unit tests

https://gerrit.wikimedia.org/r/121548

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL