Page MenuHomePhabricator

Remove "requires JavaScript" from preference texts
Closed, ResolvedPublic

Description

«Some preferences end with (requires JavaScript), but it is not consistently used, and given that practically everyone has javascript support these days, but a lot of people don't really know what it is, wouldn't it be better to remove the warnings?»

There are 6 such preferences in core.


Version: 1.21.x
Severity: minor

Details

Reference
bz44947

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:24 AM
bzimport set Reference to bz44947.

rahul14m93 wrote:

Patch Link

Attached:

rahul14m93 wrote:

Comment on attachment 11836
Patch Link

Actually a lot of users JavaScipt isnt supported. Or in other cases especially on mobile browsers it causes inconsistencies (Lynx browser does not support JavaScript)

rahul14m93 wrote:

Gerrit change 50614

removing javascript keyword since it has nothing to do with JavaScript modifications.

Rahul: Thanks for the patch!

Betacommand: See comment 0 - it's not consistently used anyway.

(In reply to comment #7)

Rahul: Thanks for the patch!

Betacommand: See comment 0 - it's not consistently used anyway.

I would prefer us to err on the other side, then. What about adding those preferences items via Javascript? (only semi-joking)

I'm not sure about removing the warning text.

Change 50614 had a related patch set uploaded by Siebrand:
(Bug 44947) Removed "requires JavaScript" from preference texts

https://gerrit.wikimedia.org/r/50614

Change 50614 merged by jenkins-bot:
Removed "requires JavaScript" from preference texts

https://gerrit.wikimedia.org/r/50614