XCache return values are not handled correctly
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	MarkAHershberger
	Feb 13 2013, 3:22 PM

Description

This was caused by mw bug (or bug in some xcache version).

xcache_get returns NULL if nothing can be acquired from cache, but mw waits for false.

if ( $this->get( $key ) === false ) {

at line 147 of includes/objectcache/BagOStuff.php, while xcache will return NULL in this case, so

for ( $i = 0; $i < MSG_WAIT_TIMEOUT && !$this->mMemc->add( $lockKey, 1, MSG_LOCK_TIMEOUT ); $i++ ) {

at line 581 of includes/cache/MessageCache.php will get timeout in 10 seconds (default value).

mediawiki 1.20.2, xcache v3.0.1

I'll report this to bugzilla if not forget.

Version: 1.20.x
Severity: normal

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:24 AM

• bzimport set Reference to bz44952.

• bzimport added a subscriber: Unknown Object (MLST).

rohieb wrote:

There is a fix in the development version, apparently: