Page MenuHomePhabricator

[Regression] Only first and last suggestion in link assistent accessible via keyboard
Closed, ResolvedPublic

Description

This bug occurs on en.wikipedia (Wikiedior 0.3.1 + MW 1.21wmf9 (070f4b4)), but not with Wikieditor 0.3.1 + MW 1.18.1 (Version 113461).
Steps to reproduce:

  1. Open any article for editing.
  2. Click the chain icon to open the link assistent.
  3. Type "a". A list of articles starting with "a" will open.
  4. Press the down-key. The first item in this list will be selected and the input updated accordingly.
  5. Press the down-key again.

Expected result: The second item should be selected.

Actual result: No item is selected, the input is reset to "a".

The same goes for the up-key, which selects only the last entry, but not the second-to-last.


Version: 1.21.x
Severity: normal

Details

Reference
bz44988

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:26 AM
bzimport set Reference to bz44988.

As this uses the module jquery.suggestions, I think this might be caused by change I87940ca8.

Yeah, my fault. Submitted If7bfb25a to fix this.

Merged, this should be fixed once the change is deployed.