Page MenuHomePhabricator

Remove user icon from personal tools in Vector and Monobook skins
Closed, DeclinedPublic

Description

As proposed at bug 35341 comment 3 (and supported at bug 35341 comment 4) and as mentioned again at bug 41484 comment 9, there's a head icon in the Vector and Monobook skins next to the username (or next to "Log in / Create account" while logged out) in the upper right corner of the browser window.

It's never been very clear to me what the purpose of this icon is beyond decoration. I think it can safely be removed from both skins.


Version: 1.21.x
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=41484

Details

Reference
bz45056

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:31 AM
bzimport set Reference to bz45056.
bzimport added a subscriber: Unknown Object (MLST).

I support this.

On the other hand, if we were to keep it, it should at least be a link (right now it's a non-clickable background image) somewhere sensible.

(In reply to comment #4)

I support this.

On the other hand, if we were to keep it, it should at least be a link (right
now it's a non-clickable background image) somewhere sensible.

Moving the styles for the icon from the li to the a inside (basically adding a single ' a' to each selector) would do that.

Though as with all css changes like that it runs the risk of conflicting with custom css.

That's the [[mw:personal tools]] bar so it's rather obvious why it has a person/personal hint. :)
I think the "my" has been killed under the assumption that the icon already serves the purpose; how will one be supposed to understand what those links are there for and how they differ from the sidebar?
Fixing bug 41484 doesn't seem that hard, all sites have such icons and better ones. It may be better to kill (collapse) the personal tools bar than (behind) the icon, to reduce clutter, as most sites do...

"our" bugzilla has the same icon.

You can try it out on a wikipedia by changing the common.css and when there is no bad response, than kill it for every one. Can be part of the E3?

(In reply to comment #8)

(I abandoned my patch.)

Closing per this, commit comments and lack of a rationale (https://bugzilla.wikimedia.org/show_bug.cgi?id=41484#c26 ).

Good, let's try to sum up problems:

(1) user icon does not indicate that a whole bunch of menu items is somehow "personal". I'd say it is 'next to my username', but I wouldn't say it somehow influences the meaning of the following links.

When using the text browser, I can clearly see:

Personal tools

• Saper
• 1
• Talk
• Preferences
• Watchlist
• Contributions
• Log out

Apart from "1" which looks meaningless (bug 53928), everything is pretty clear.

(2) Some older skins made it difficult to tell links like "logged-in" user contributions vs. "contibutions of the user, whose page your are currently watching" apart.

Looking at HTML, again, things become pretty clear:

Personal tools

• Saper
• 1
• Talk
• Preferences
• Watchlist
• Contributions
• Log out

vs.

Toolbox

• What links here
• Related changes
• User contributions
• Logs
• Block user
• Email this user
• User rights management

I think there is little doubt that "user contributions" here belong to the user page I am watching, not to "my contributions". If this needs further explanation, needs to be fixed and icon does not help in my opinion

(3) When not logged in, we have

Personal tools

• Create account
• Log in

In the full screen graphical browser, the "user icon" is stuck between "Create account" and "Log in". Why? What does it mean? Is "Log in" more personal than "Create account"? I think it should be removed there in the first place.

(4) and there is bug 41484

If personal-vs-page-toolbox disambiguity is the problem, we need to work on the personal tools and toolbox at the same time; adding this icon does not really help (would adding a "page" icon in the toolbox improve its readability? I think no).

ritusparks wrote:

Hey! I would like to work on this bug! Could someone assign me the bug?

Please also see the related comments in https://gerrit.wikimedia.org/r/#/c/49367/ - currently this is assigned to MatmaRex.

Is it? It should not be. Sorry, I've had it with these gender-neutrality bugs.

Change 146979 had a related patch set uploaded by Nemo bis:
Make profile icon gender neutral and remove from login link

https://gerrit.wikimedia.org/r/146979

Make profile icon gender neutral and remove from login link

https://gerrit.wikimedia.org/r/146979

The patch by Rob Moen proposes to remove the link completely for unregistered users from Vector. I assume the rationale is that they're not personal tools until there is some tool, and that "Log in" is clearly personal by its label alone. Things to clarify:
a) whether this is ok for the cases when the space *is* used for personal tools even for unregistered users, e.g. by extensions or user scripts (think of a "sandbox" link);
b) whether it makes sense for Vector to be inconsistent with monobook (this less important).

swalling wrote:

(In reply to Nemo from comment #15)

Make profile icon gender neutral and remove from login link

https://gerrit.wikimedia.org/r/146979

The patch by Rob Moen proposes to remove the link completely for
unregistered users from Vector. I assume the rationale is that they're not
personal tools until there is some tool, and that "Log in" is clearly
personal by its label alone.

Things to clarify:

a) whether this is ok for the cases when the space *is* used for personal
tools even for unregistered users, e.g. by extensions or user scripts (think
of a "sandbox" link);

When the space is used for personal tools even for unregistered users, the icon appears. I tested to confirm this locally.

b) whether it makes sense for Vector to be inconsistent with monobook (this
less important).

Vector is obviously meant to be inconsistent with monobook in a wide variety of ways. It's a different skin.

(In reply to Steven Walling from comment #16)

When the space is used for personal tools even for unregistered users, the
icon appears. I tested to confirm this locally.

Can you attach a screenshot? The only CSS rule I see in the patch is whether a #pt-anonuserpage is present or not.

swalling wrote:

(In reply to Nemo from comment #17)

(In reply to Steven Walling from comment #16)

When the space is used for personal tools even for unregistered users, the
icon appears. I tested to confirm this locally.

Can you attach a screenshot? The only CSS rule I see in the patch is whether
a #pt-anonuserpage is present or not.

Sure. Screenshots for all three now on Commons.

  • The normal unregistered case is [[commons:File:Screenshot of new Vector personal toolbar unregistered.png]]
  • The nonstandard case for Wikimedia is [[commons:File:Screenshot of new Vector user icon unregistered.png]]
  • And when logged in is [[commons:File:Screenshot of new Vector user icon logged in.png]]

Is this icon perfect? Hard to say. Is it gender-less and far more neutral overall? Yes. Growth wanted to update this since the bug has been sitting around in bikeshedding mode for way too long, and there are a bajillion different options we could argue about forever (like the list at http://thenounproject.com/search/?q=user).

Change 157990 had a related patch set uploaded by Robmoen:
Make profile icon gender neutral and remove from login link in Vector

https://gerrit.wikimedia.org/r/157990

Change 146979 abandoned by Robmoen:
Make profile icon gender neutral and remove from login link in Vector

Reason:
Abandoned in favor of new patch in skins directory.
https://gerrit.wikimedia.org/r/#/c/157990/

https://gerrit.wikimedia.org/r/146979

Change 157990 merged by jenkins-bot:
Make profile icon gender neutral and remove from login link in Vector

https://gerrit.wikimedia.org/r/157990

(The icon was changed and not removed, and it seems it's not going to be removed, so I'm changing resolution to WONTFIX.)