Page MenuHomePhabricator

Load editing toolbar on element ready instead of content ready
Closed, InvalidPublic

Description

Apparently the editing toolbar currently loads on content ready after the entire page finishes loading. Since said entire page can take quite awhile and people often want to start editing before that and the toolbar moves the textarea down when it loads, as well as potentially otherwise messing up anyone who has already tried to start editing, it should really be loading as soon as the relevant stuff is ready instead of waiting for everything else too.


Version: 1.21.x
Severity: normal

Details

Reference
bz45145

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:38 AM
bzimport set Reference to bz45145.
bzimport added a subscriber: Unknown Object (MLST).

Just curious, what exactly is the "rest" of the page on EditAction after the main <textarea> before </html>?

Afaik the output between those two points in the output are a straight forward buffer output, no additional expensive or slow actions (e.g. "templates used" is calculated before hand).

From EditPage::showEditForm:

  • edit toolbar
  • showTextbox1
  • standard inputs
  • edit tools
  • templates used
  • (hidden) categories

Also, the WikiEditor extension itself loads from the bottom queue, which is asynchronous and doesn't block the document-ready event so basically everything executes straight away already.

There is certainly room for optimisation, but it's not as simple as changing the $(document).ready binding to something else.

This bug is not about the WikiEditor toolbar (that one's Bug 45144), but the normal one that ships with core.

Now what you said may be the case with the regular editing toolbar too, but frankly all I really know is both of them wait to activate and that causes problems for people.

It's true that this happens. For me it's much rarer than in WikiEditor (where it's certain to happen + bug 41911), but this is no indication of how common it may be.

  • Bug 45144 has been marked as a duplicate of this bug. ***
Jdforrester-WMF subscribed.

The 2006 wikitext editor, to which this refers, has been removed from MediaWiki and Wikimedia servers, and so this task is no longer valid.