Page MenuHomePhabricator

VisualEditor: newFromWrap() should perform validation
Open, LowPublicFeature

Description

ve.dm.Transaction.newFromWrap() currently doesn't check that the transaction it generates will be valid. That is, it will ensure that things are unwrapped correctly, but it doesn't check that the result doesn't end up violating parent/child restrictions.

It's not entirely clear to me whether we should try to rectify that or throw an exception, but either of those is better than generating a transaction that, when applied, will make the document nonconformant.


Version: unspecified
Severity: enhancement

Details

Reference
bz45183

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:40 AM
bzimport added a project: Technical-Debt.
bzimport set Reference to bz45183.
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:13 AM
Aklapper removed a subscriber: TrevorParscal.