Page MenuHomePhabricator

question mark skipped in "edit links" link
Closed, ResolvedPublic

Description

If click the edit links link on http://en.wikipedia.org/wiki/Do_Androids_Dream_of_Electric_Sheep? to get to Wikidata, Wikidata can´t find the item. The question mark in the title is removed on Special:ItemByTitle.


Version: master
Severity: normal
URL: http://en.wikipedia.org/wiki/Do_Androids_Dream_of_Electric_Sheep?
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44536

Details

Reference
bz45223

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:14 AM
bzimport set Reference to bz45223.
bzimport added a subscriber: Unknown Object (MLST).

The bug description is wrong.

The cause of the bug is because the question mark isn't properly escaped and then becomes a separator for the query part of the URL. In this case it should be part of the filepath, or in mediawiki-lingo the title of the page.

Basically the title isn't escaped properly on the client.

I think the following should be sufficient to solve this bug, and its independent on whether we should link directly on the id itself. https://gerrit.wikimedia.org/r/#/c/51956/

Bug 44536 relates to this one as it replaces the linking to the special page with linking to the id. Still note that of this writing the changeset is broken.

Verified in Wikidata demo sprint 34

*** Bug 46019 has been marked as a duplicate of this bug. ***

Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript