Page MenuHomePhabricator

[TUX] Do not consider empty string to mark a translation as "unsaved"
Closed, ResolvedPublic

Description

When the user edits an untranslated message by adding and removing some text. The translation is empty but by closing the editor, the message is marked as "unsaved" leading to the wrong impression that there are unsaved changes.


Version: master
Severity: minor

Details

Reference
bz45493

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:31 AM
bzimport set Reference to bz45493.

dev.malkum wrote:

Couldnot repro. Can you provide a screenshot or more repro steps.

dev.malkum wrote:

Hmm. Then what is the actual case where we show the status as "unsaved". I am thinking only those two scenarios.

(In reply to comment #3)

Hmm. Then what is the actual case where we show the status as "unsaved". I am
thinking only those two scenarios.

We need to show "unsaved" if the original translation is not equal to the translation just before closing or skipping. ie, you have a valid change that is not saved yet.

Patch in gerrit I59b5b4d1811cf435c72d7796eff6fa6222fb77e1