Page MenuHomePhabricator

Watching or unwatching removes the Change Subject link
Closed, ResolvedPublic

Description

When clicking on watch or unwatch the 'Change Subject' link disappears.


Version: master
Severity: normal

Details

Reference
bz45618

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:39 AM
bzimport set Reference to bz45618.

...only if javascript is enabled.

I investigated this issue, on clicking 'watch' $.load() is executed which tries to rebuild the command menu by retrieving from the server.. This is wrong and we should be able to build it on client side without interacting with the server.

The actual error happens because the 'Change Subject' button is not build in PHP but in JS which doesn't appear using load()

Patch depends on patch for bug 45329, hence adding dependency.

Change 51834 merged by jenkins-bot:
Watching and Unwatching made 'Change Subject' disappear.

https://gerrit.wikimedia.org/r/51834