Page MenuHomePhabricator

"None" option doesn't display in Opera or IE
Closed, ResolvedPublic

Description

Author: andreas.vilen

Description:
On the upload page for commons, there should be an option "none", in the multiple choice list. In IE or Opera (and
possibly other browsers), the none option is not shown, because the code is misinterpreted as "<option value=''>".
The code looks like

<option value=''>None selected</option>
<option value="Unknown" title="{{Unknown}}">I don't know what the license is</option>

It should be (I guess) option value="" instead. It works in Firefox, but not in Opera or IE, and since still most
users use IE this should be fixed.

This is somewhat critical since users using other browsers than Firefox can't upload images with a certain licence
tag without lying about the tag (as in choosing a random licence tag in the list) and later changing it manually.

Thank you very much in advance!


Version: unspecified
Severity: major
OS: Windows XP
Platform: PC
URL: http://commons.wikimedia.org/wiki/Special:Upload

Details

Reference
bz4576

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:01 PM
bzimport set Reference to bz4576.
bzimport added a subscriber: Unknown Object (MLST).

avarab wrote:

(In reply to comment #0)

It should be (I guess) option value="" instead. It works in Firefox, but not

in Opera or IE, and since still most

users use IE this should be fixed.

You guess or you've tried that and it works? Please say what exact user agent
you're using.

andreas.vilen wrote:

I guessed, didn't check. I checked now, and the code shows like

<option value=''>None selected</option>
<option value="Unknown" title="{{Unknown}}">I don't know what the license is</option>

in Firefox too... In Firefox though, I see the "none" value, which I'm sure you also do. I don't know if the
problem is browser specific, but it should in some way be fixed so that IE and Opera users also can upload images
properly. I don't know anything about coding myself.

Close, but the problem was actually the missing '>' on the line above,
which caused the <select> to not be closed properly.

Single-quotes are perfectly ok on XML/HTML attributes.

Fixed in SpecialUpload.php revision 1.100.