PHP fatal error when saving banner edits in Special:NoticeTemplate
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Tbayer
	Mar 7 2013, 3:34 PM

Description

PHP fatal error on Special:NoticeTemplate (2013-03-07)

Editing a banner (https://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=FDCpropreview20031 ) and clicking "Save banner" resulted in a "Wikimedia Foundation error" page with the following error message:

"PHP fatal error in /usr/local/apache/common-local/php-1.21wmf11/extensions/CentralNotice/special/SpecialNoticeTemplate.php line 919:
Call to a member function logBannerChange() on a non-object"

Reproduced it in a second edit to the same banner. Both edits saved fine (e.g. https://meta.wikimedia.org/w/index.php?diff=prev&oldid=5304256 ).

Version: unspecified
Severity: normal

Attached:

Special_NoticeTemplate_PHP_fatal_error_2013-03-07.png (864×1 px, 144 KB)

Details

Reference: bz45846

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:27 AM

• bzimport added a project: MediaWiki-extensions-CentralNotice.

• bzimport set Reference to bz45846.

• Tbayer created this task.Mar 7 2013, 3:34 PM

That's the first time $bannerObj is used, so it's obviously a non-object!

Introduced by https://gerrit.wikimedia.org/r/50768, assigning to Matt Walker

mwalker wrote:

Gah! I thought I fixed this... oh well; here's the patch: https://gerrit.wikimedia.org/r/52639

mwalker wrote:

Pushed to cluster.

PHP fatal error when saving banner edits in Special:NoticeTemplateClosed, ResolvedPublicActions

Description

Details

Event Timeline

PHP fatal error when saving banner edits in Special:NoticeTemplate
Closed, ResolvedPublic
Actions