Page MenuHomePhabricator

Mention notifications targeting non existing users should not be fired
Closed, ResolvedPublic

Description

Currently they are stored with a recipient user_id set to 0, see for example User:Okeyes in http://www.mediawiki.org/w/index.php?title=User_talk:LWelling&diff=prev&oldid=656919


Version: unspecified
Severity: normal

Details

Reference
bz46046

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:40 AM
bzimport added a project: Notifications.
bzimport set Reference to bz46046.

Looks like the code only saves the user_id, so pretty much any action where it's 0, it should be ignored/skipped/whatever, as there's no way to differentiate between anon/non existent users...

In the maintenance script:

				$userId = intval( $row->eeb_user_id );
				if ( $userId && $userId > $startUserId ) {
					$emailBatch = MWEchoEmailBatch::newFromUserId( $userId );

Merged by Kaldari on the 15th.