Page MenuHomePhabricator

Uploading many short file names fails
Closed, DeclinedPublic

Description

With a current nightly build, I tried uploading files with these names, and they all failed (after reaching 100% uploaded):

wat
huh?
wat¿
b...
b....
....b
b....b

The following filenames did not fail:
B.bbb
.scream
Wat?.m.m.m.m.
Beer
Nooo!
Huh huh huh?
Wat wat wat
watwatwat

(Perhaps the pattern is, it needs more than three non-punctuation characters in the title?)

That was all earlier today. As of right now, every upload I start from the app fails immediately (before uploading), and sending an file to the app via intents causes a crash immediately upload pressing Upload.


Version: unspecified
Severity: normal

Details

Reference
bz46054

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:41 AM
bzimport set Reference to bz46054.
bzimport added a subscriber: Unknown Object (MLST).

Unsure how to fix the titleblacklist issue. But the crash issue should be fixed with 10b7a97f6699841027eb60cc7609bff2fea2a720

Yes, probably the blacklist. The app itself should do a very basic check (is the title long enough?) and then blacklist failures should return a more specific message than "Failed" (and should not permit retry with the same name).

You should get back different error codes for the upload system saying your name is too short and for TitleBlacklist rejecting the title...

UploadBase::getTitle() does the check on the extension, and returns a specific error which should come back as 'filename-tooshort'.

Did this get resolved after appending explicit file extensions or is it still happening?

It's mostly title blacklist / other blacklists, rather than extensions

As the Mobile Apps Team is focussing on the new, native Wikipedia app, the Commons app is no longer being maintained by the Wikimedia Foundation. I am WONTFIXing all open Commons app bugs to reflect that we will not be spending time fixing them.

For the full story, see this thread on mobile-l: https://lists.wikimedia.org/pipermail/mobile-l/2014-September/thread.html#7974