Page MenuHomePhabricator

Semantic Maps 2.0.1.2 distance queries broken.
Closed, ResolvedPublic

Description

Author: mitchell_neill

Description:
Hi.

I'm running SMW 1.8.0.4, Maps 2.0.1, Semantic Maps 2.0.1.2, Validator 0.5.1 on MW 1.19.4.

{{#ask:[[Category:Organisations]][[Coordinates::{{#var:lat_long}} 10km]]|?Headline=|?Address|?Location|?Postcode|?Coordinates|center={{#var:lat_long}}|format=googlemaps|width=920|height=640|forceshow=yes|icon=Flag_red.png|zoom=12|autozoom=off|limit=100|searchlabel=}}

and it shows an error:
"The following coordinate was not recognized: 50 50' 48" N, 1 28' 9" W 10km"

This works on a previous version of the same site running Maps 1.0.5 and Semantic Maps 1.0.5.

In fact, even the example at http://semantic-mediawiki.org/wiki/Semantic_Maps_examples/Distance_query is showing an error. It is only showing anything because the way SMW defaults to outputting all results if the query has an error.

Thanks.


Version: master
Severity: normal

Details

Reference
bz46371

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:33 AM
bzimport set Reference to bz46371.
bzimport added a subscriber: Unknown Object (MLST).

mitchell_neill wrote:

I tried putting the distance in brackets like the example (although it's always worked before without)

{{#ask:[[Category:Organisations]][[Coordinates::{{#var:lat_long}}
(10km)]]|?Headline=|?Address|?Location|?Postcode|?Coordinates|center={{#var:lat_long}}|format=googlemaps|width=920|height=640|forceshow=yes|icon=Flag_red.png|zoom=12|autozoom=off|limit=100|searchlabel=}}

But then no map is shown at all.

Even if the parsing part worked, the query code has a bad off by one error in it... The later has been fixed on master, the former still needs tackling.

mitchell_neill wrote:

Thanks for the update Jeroen. Looking forward to the final fix :)

Chippyrof wrote:

It would be nice to see this fixed and also some working examples of this extension actually working as well as documentation of any sort.

dan.bolser wrote:

(In reply to comment #4)

It would be nice to see this fixed and also some working examples of this
extension actually working as well as documentation of any sort.

I've done some work on migrating (the very comprehensive) documentation from http://mapping.referata.com/wiki/User_manual to http://semantic-mediawiki.org/wiki/Maps

Please help!

Dan.

dan.bolser wrote:

(In reply to comment #2)

Even if the parsing part worked, the query code has a bad off by one error in
it... The later has been fixed on master, the former still needs tackling.

Where should we look to start work on this?

mitchell_neill wrote:

Looks like users of SMW 1.8+ are stuffed. Upgrading existing sites to SMW 1.8+ is also not possible if mapping is required because of this bug :(