Page MenuHomePhabricator

If web notifications are turned off the yellow bar of death does not return
Closed, ResolvedPublic

Description

Need to make sure that the yellow bar works when web notifications are turned off.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47743

Details

Reference
bz46550

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:18 AM
bzimport added a project: Notifications.
bzimport set Reference to bz46550.
bzimport added a subscriber: Unknown Object (MLST).

bsitu wrote:

This seems to work fine but the problem is that option echo-notify-hide-link disappears in preference

bsitu wrote:

(In reply to comment #1)

This seems to work fine but the problem is that option echo-notify-hide-link
disappears in preference

Never mind, looks like both echo-pref-notify-hide-link and echo-notify-link are not used anymore, I submitted a patch to clean them up: https://gerrit.wikimedia.org/r/#/c/59024/

Related URL: https://gerrit.wikimedia.org/r/59086 (Gerrit Change Ifc8fbaf8fdc96f9c18c2a889d2e854e49b3a7010)

Fixed in Echo change If21f3aac and core change Ifc8fbaf8. Waiting for review.

Related URL: https://gerrit.wikimedia.org/r/59876 (Gerrit Change Ifc8fbaf8fdc96f9c18c2a889d2e854e49b3a7010)

Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript