Page MenuHomePhabricator

[Regression] mw.loader.addEmbeddedCSS throws cssText.indexOf is not a function
Closed, ResolvedPublic

Description

(Quote from bug 46401 comment #2)

http://commons.wikimedia.org/wiki/Commons:
FORUM#komprimiertes_JavaScript_kaputt.3F
https://commons.wikimedia.org/wiki/Commons:
Village_pump#Strange_problem_with_CSS
https://en.wikipedia.org/wiki/Wikipedia:
Village_pump_%28technical%29#CSS_errors_with_search_box.2C_etc..3F
https://en.wikipedia.org/wiki/Wikipedia:
Village_pump_%28technical%29#Errors_with_editing_interface_and_sidebar

Only affects Firefox.


Version: 1.21.x
Severity: critical

Details

Reference
bz46575

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:19 AM
bzimport set Reference to bz46575.

Caused by passing addEmbeddedCSS to setTimeout directly.

Which is a problem in Firefox (below version 13) due its non-standard
behaviour of passing a numerical "lateness" value as first argument to this
callback.

See also
http://benalman.com/news/2009/07/the-mysterious-firefox-settime/

Change-Id: I80af730daa815f0c273fe942c570d1f0144bbbb1

(In reply to comment #1)

Change-Id: I80af730daa815f0c273fe942c570d1f0144bbbb1

Merged and deployed to 1.21wmf12.

Related URL: https://gerrit.wikimedia.org/r/59571 (Gerrit Change I80af730daa815f0c273fe942c570d1f0144bbbb1)