https://gerrit.wikimedia.org/r/#/c/56196/

verified.

peace.

inkbug200 wrote:

Hi.
It seems this is broken again (see top of https://he.wikisource.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%98%D7%A7%D7%A1%D7%98:%D7%9E%D7%96%D7%A0%D7%95%D7%9F). Should I report a new bug or should this one be reopened?

Thank you!

Thanks! I'll reopen this ticket as people are already CC'ed on it.

This broke in 164a6469b6d95c447869a1a427a66150b76a2c58 / gerrit 102522 because of https://translatewiki.net/w/i.php?title=MediaWiki:Sp-translate-data-MagicWords/he&oldid=5207443

If possible, please replace the localised magic word with a canonical version.

Also, please do not use spaces in local version of magic words. I've made these[1] changes that will be committed tomorrow and should be part of MediaWiki 1.23wmf9.

[1] https://translatewiki.net/w/i.php?title=MediaWiki%3ASp-translate-data-MagicWords%2Fhe&diff=5236283&oldid=5207443

(In reply to comment #6)

If possible, please replace the localised magic word with a canonical
version.

there is good reason to use localized magic words: mixing RTL and LTR (aka "bidi") is a bitch for editing. in many cases, the ability to use RTL magic words makes editing so much easier. it is unfortunate that we can't use translated tags (there is an extension that enables it also, but unfortunately it's not deployed in wikimedia wikis). peace - ~~~~

(In reply to comment #7)

Also, please do not use spaces in local version of magic words. I've made
these[1] changes that will be committed tomorrow and should be part of
MediaWiki 1.23wmf9.

[1]
https://translatewiki.net/w/i.php?title=MediaWiki%3ASp-translate-data-
MagicWords%2Fhe&diff=5236283&oldid=5207443

this does not seem right. as far as i could see, the issue here is spaces vs. underlines, so it's "חשב תנאי" vs. "חשב_תנאי". Siebrand added the variant "חשבתנאי", which, to the best of my knowledge, is not used anywhere. iiuc, we should either add back the "חשב תנאי" string (space instead of underline), or better yet, train the parser to create the "other" space/underline variant automagically when it encounters a magic word which contains either.

peace.

rotemliss wrote:

I deleted "MediaWiki:Sp-translate-data-MagicWords" in translatewiki.net, that seems to have caused this bug (twice).

It is far too late now to break backwards compatibility and remove a translated magic word that was translated in 2006 (or maybe 2007), just because of technical problems in translatewiki.net. Please note that removing the space does not solve the problem, and anyway, is not standard in Hebrew. Therefore, the original magic word should be added back.

Fixed

I reverted the change in gerrit: https://gerrit.wikimedia.org/r/#/c/104752/
and it is now merged and deployed (thanks for Chad)

i still think that it will be a good idea to teach the bot that moves stuff from traslatewiki to mediawiki code base to create both variants when the original string contains either underline or space.

the original "fix" from Siebrand (the one that was reverted) seems like it's possible to have multiple names (aliases?) for the same keyword/magic word. if this is indeed so, changing the bot that moves stuff from translatewiki to mediawiki seems to be the best solution

peace.

Resetting Importance fields to the values set by Siebrand, as per https://www.mediawiki.org/wiki/Bugzilla/Fields#importance . Thanks.

If the patch was merged, we can mark this as resolved.

We can leave Bug 59165 for tracking how we souldn't break it again ;)