| QChris | |
| Apr 2 2013, 8:50 AM |
| F8393471: Screen Shot 2017-06-06 at 23.10.37.png | |
| Jun 6 2017, 10:11 PM |
As per
http://lists.wikimedia.org/pipermail/wikitech-l/2013-April/067995.html
- the "add comment" feature doesn't allow you to write a comment while
viewing the code or viewing the other comments, resulting in an awful
workflow for me when attempting to write a comment.
Version: wmf-deployment
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T48776 Add 'reply' button to Gerrit comments that quotes the original comment | |||
| Resolved | None | T48777 "add comment" feature doesn't allow you to write a comment while viewing the code or viewing the other comments | |||
| Resolved | • demon | T156120 Update gerrit to 2.14.6 | |||
| Open | None | T184086 Add prometheus exporter to Gerrit | |||
| Resolved | • demon | T184116 Setup gitiles for use with gerrit as a repo viewer |
When logged in, pressing 'r' (/r/eview) while viewing code
or viewing other comments, opens the review (='add comment')
page and takes you right to the comment's cover message.
Does that solve the issue?
(In reply to comment #1)
Does that solve the issue?
No.
Also (not for this bug but I was just bitten by this) RT doesn't allow viewing other comments / attachments / history while composing either.
I guess some UX person could come up with something better but a good first step would be to show the comment box below the existing comments like Bugzilla does. So when hitting r, the input box would add to the page rather than replacing part of the page.
(In reply to comment #1)
When logged in, pressing 'r' (/r/eview) while viewing code
or viewing other comments, opens the review (='add comment')
page and takes you right to the comment's cover message.
The "R" shortcut just seems to be the equivalent of pressing the "Add comment" button. In both cases, the issue is that the list of changes and the comments all become inaccessible after doing either currently.
We can either keep this task open until polygerrit is rolled out on wikipedia's gerrit or we can close this as declined as this is fixed in polygerrit as you can now view diffs without leaving the comments section. You press a button an it shows the diff.
It also saves your comment for a little bit too.
GWTUI is being removed upstream. This looks some what done in polygerrit as you can click a button that shows the diff for all files without entering the file to see the diff, thus allowing you to write a comment when reviewing the diff.
GWTUI is the ui you currently see when going to gerrit.wikimedia.org/r/ at the time of this comment.
PolyGerrit stores comments data in the local storage on the browser on the device now, which means you have time to view diffs with the comment with the reply comment waiting to be edited or published.
