Page MenuHomePhabricator

Don't allow someone to thank the same person twice for the same revision
Closed, ResolvedPublic

Description

Author: swalling

Description:
Currently, if the user hard refreshes the page or opens another view of the same revision (say, diff view when you were previously on History), you can thank the same user twice for the same revision.

This is potentially very confusing, since it appears like your previous thank you did not take effect. We should do our best to disallow this.

I understand that, in order to keep this feature lightweight, we're not creating database tables etc. to keep a log of thanks. And that's probably good since it could easily grow right along with revision tables once enabled.

As an interim solution, I'd support even a half-measure like preventing duplicate thanks for 24 hours at least, such as by remembering the thank yous for the duration of your session (tied to the session cookie, maybe using memcached, etc.).


Version: unspecified
Severity: normal

Details

Reference
bz46820

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:37 AM
bzimport added a project: Thanks.
bzimport set Reference to bz46820.
bzimport added a subscriber: Unknown Object (MLST).
  • This bug has been marked as a duplicate of bug 46690 ***