Remove page-object gem deprecation warnings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	zeljkofilipin
	Apr 4 2013, 2:21 PM

Description

This will cause page-object gem deprecation warning:

$ bundle exec cucumber features/page.feature:44
Using the default profile...
..*** DEPRECATION WARNING

You are calling a method named a at /Users/z/project/wmf/browsertests/features/support/pages/article_page.rb:18:in `block in <class:ArticlePage>'.
This method does not exist in page-object so it is being passed to the driver.
This feature will be removed in the near future.
Please change your code to call the correct page-object method.
If you are using functionality that does not exist in page-object please request it be added.

......

1 scenario (1 passed)
8 steps (8 passed)
0m22.284s

Example in Jenkins:

https://wmf.ci.cloudbees.com/job/_debug-browsertests-template/92/console

There are four deprecation warnings in the entire test run:

https://wmf.ci.cloudbees.com/job/browsertests-linux-chrome/258/console

Fix the code so the warnings no longer appear.

Version: unspecified
Severity: normal

Details

Reference: bz46893

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:42 AM

• bzimport added projects: Quality-Assurance, good first task.

• bzimport set Reference to bz46893.

zeljkofilipin created this task.Apr 4 2013, 2:21 PM

Make sure to fix deprecation warning in both qa/browsertests and mediawiki/extensions/MobileFrontend

tplavcic wrote:

Question: for MobileFrontend there is only one line that should be updated and that is in file:
tests/acceptance/features/support/pages/search_page.rb
line: page.search_results_element.a
should be: page.search_results_element.element.a

Should I make a commit just for this or somebody else will update it when doing some bigger commit?

Implemented for qa/browsertests in https://gerrit.wikimedia.org/r/#/c/74091/

Tomislav, please make the commit.

Change 75818 had a related patch set uploaded by Plavi:
QA: Remove page-object gem deprecation warnings

https://gerrit.wikimedia.org/r/75818

Change 75818 merged by jenkins-bot:
QA: Remove page-object gem deprecation warnings

https://gerrit.wikimedia.org/r/75818

tplavcic wrote:

I think this bug can be closed because all of the initial problems were fixed here: https://gerrit.wikimedia.org/r/#/c/74091/
and here: https://gerrit.wikimedia.org/r/75818

I know there's another similar bug (54590) for VE but that's going to be closed there...

Jeff fixed a couple for us just now: https://github.com/cheezy/page-object/issues/192

Remove page-object gem deprecation warningsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Remove page-object gem deprecation warnings
Closed, ResolvedPublic
Actions