Page MenuHomePhabricator

repoupdate breaks for "half-existing" extensions. Better error handling needed
Closed, DeclinedPublic

Description

Running /resouces/raymond/repoupdate mediawiki-extensions breaks for a "half existing extension".

Better error handling needed:

Creating a git remote called "gerrit" that maps to:

ssh://l10n-bot@gerrit.wikimedia.org:29418/wikimedia/fundraising/DonationEmailUnsubscribe.git

<traceback object at 0x2607c20>
We don't know where your gerrit is. Please manually create
a remote named "gerrit" and try again.
Traceback (most recent call last):

File "/usr/local/bin/git-review", line 863, in <module>
  main()
File "/usr/local/bin/git-review", line 798, in main
  config['hostname'], config['port'], config['project'])
File "/usr/local/bin/git-review", line 389, in check_remote
  add_remote(hostname, port, project, remote)
File "/usr/local/bin/git-review", line 259, in add_remote
  raise Exception("Error running %s" % cmd)

Exception: Error running git remote add -f gerrit ssh://l10n-bot@gerrit.wikimedia.org:29418/wikimedia/fundraising/DonationEmailUnsubscribe.git


Restarting the script works.


Version: unspecified
Severity: normal

Details

Reference
bz46900

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:43 AM
bzimport set Reference to bz46900.
bzimport added a subscriber: Unknown Object (MLST).

What is a half existing extension?

The traceback is useless to me. Perhaps someone who knows git-review more closely would know.

A "half existing extension" is my wording for an extensions that is somehow created but breaks our script :-)

Raimond, is the script still exiting prematurely on "bad repos", or do we finally have this under control?

(In reply to comment #3)

Raimond, is the script still exiting prematurely on "bad repos", or do we
finally have this under control?

Long time not seen ---> FIXED for now.