Page MenuHomePhabricator
Create Task
Maniphest T49131

Make sure notification counts are reset after user changes subscription options
Closed, ResolvedPublic
Actions

Description

Not sure if this is handled yet, when a notification type is dismissed from either the preference page or notification page, the notification count reset function should be called so a new count would be generated.

Version: unspecified
Severity: normal

Details

Reference
bz47131

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:29 AM
• bzimport added a project: Notifications.
• bzimport set Reference to bz47131.
kaldari created this task.Apr 11 2013, 5:26 PM
kaldari added a comment.Apr 12 2013, 9:06 PM

Whether this is done through the prefs or the options API, the change is handled by User::saveSettings() which does clear the user cache.

gerritbot added a comment.Apr 12 2013, 10:13 PM

Related URL: https://gerrit.wikimedia.org/r/59016 (Gerrit Change I5244ef9f7bf9d1217c0c0df6691d8cf689c47cf5)

kaldari added a comment.Apr 12 2013, 10:17 PM

Forgot about the count itself needing to be updated, besides the cache. Fixed in 59016 (linked above).

Aklapper added a comment.Apr 12 2013, 10:29 PM

-> "patch-in-gerrit" (patch-need-review is only for patches in Bugzilla)

kaldari added a comment.Apr 12 2013, 10:32 PM

Shit, I've been doing it wrong this whole time :P

Krenair added a comment.Apr 12 2013, 10:43 PM

Merged.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL