jQuery.makeCollapsible: support table captions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Apr 11 2013, 9:15 PM

Description

Author: michael

Description:

When a table is collapsed, the caption remains visible. It should be hidden too, as part of the table’s content. (I’m referring to the table’s <caption> element, not the first table row where the collapse button resides.)

If the customToggle is placed within the table caption, it fails to work. It should be made to work in this case, and in this case the table should collapse and leave the caption visible instead of the first row.

Version: unspecified
Severity: enhancement
Whiteboard: gci2013 https://www.mediawiki.org/wiki/Google_Code-In#Candidate_tasks

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:30 AM

• bzimport set Reference to bz47139.

Thanks for taking the time to report this!
Is there any testcase available for this?

michael wrote:

Test cases:

Feel free to edit the page to add more tests, correct my errors, or whatever.

This should be easy enough; +easy.

Change 96773 had a related patch set uploaded by Areke:
jQuery.makeCollapsible: Allow support for table captions

Change 96773 abandoned by Bartosz Dziewoński:
jQuery.makeCollapsible: Allow support for table captions

Reason:
The GCI task [1] was unclaimed. If you want to continue working on this, click the "Restore Change" button.

Change 97348 had a related patch set uploaded by Theopolisme:
jquery.makeCollapsible: collapse to caption support

@Michael, I've written (/am working on) a patch for this that follows the following logic -- could you let me know if it seems okay?

If the table has a caption, collapse to the caption, rather than the first row.

__ Expanded state __

Caption [collapse]
Text Text
More text Text and stuff

__ Collapsed state __

Caption [expand]

michael wrote:

That looks great!

Change 97348 merged by jenkins-bot:
jquery.makeCollapsible: collapse to caption support

Done. Thanks!