Page MenuHomePhabricator
Create Task
Maniphest T49145

Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open, HighPublic
Actions

Description

jQuery UI has been deprecated since 2017. Despite this it is widely used in Wikimedia code.

Plan

Step 1: Migrations

We can either add local versions of jQuery UI to extensions (in the case of isolated usages of this code) or port each of the features over to Codex

  • Remove usage in CodeEditor (T323330)
  • Remove usage in CodeMirror (T323329)
  • Remove usage in DonationInterface (T323328)
  • Remove usage in GWToolset (T323327)
  • Remove usage in MassMessage (T187992)
  • Remove usage in PageTriage (T323552)
  • Remove usage in RevisionSlider (T323326)
  • Remove usage in WikiEditor (T209059)
  • Remove usage in Wikilove (T323311)

Step 2: Wikidata migrations (T323333)

Add localized version of this library to Wikibase: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/921503

Step 3: Translate migration (T323332)

Perhaps it might make sense for Translate to have a localized version of this library ext.translate.jquery.ui since they are not enabled on all wikis.

  • Remove usage in Translate

Step 4: : Migrations for code in code stewardship review

Step 5: Removal

Details

Reference
bz47145
SubjectRepoBranchLines +/-
Remove unused jquery.ui modulemediawiki/extensions/Collectionmaster+0 -1
Replace sortable with bare bones up and down arrowsmediawiki/extensions/Collectionmaster+56 -8
WIP: Remove jquery.ui and ability to drag threadsmediawiki/extensions/LiquidThreadsmaster+1 -419
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson added a parent task: T54775: jQuery UI 'x' close icons look awful in Firefox depending on zoom setting.Dec 7 2015, 4:57 PM
Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jan 18 2016, 11:43 PM
Paladox subscribed.May 15 2016, 3:42 PM
Legoktm subscribed.Sep 8 2016, 8:38 PM

Does rMW9e712ce6382f: Deprecate various ResourceLoader modules count as "formally deprecating"?

Jdforrester-WMF added a comment.Sep 8 2016, 8:44 PM
In T49145#2620867, @Legoktm wrote:

Does rMW9e712ce6382f: Deprecate various ResourceLoader modules count as "formally deprecating"?

I understood that the plan was to do the "stopped using jQuery UI in extensions and core" bit, then (this task) announcing that it was deprecated and would eventually be removed.

Paladox added a comment.Sep 8 2016, 8:55 PM

All extensions should be updated, but shoulden we be using ooui instead of mw ui, I thought mw ui is also deprecated and replaced by ooui?

matmarex closed subtask T114934: Implement a slider widget in OOJS UI as Declined.Sep 10 2016, 4:30 PM
• Mattflaschen-WMF unsubscribed.Sep 26 2016, 11:59 PM
Krinkle awarded a token.Nov 2 2016, 12:10 AM
Krinkle unsubscribed.
Ladsgroup subscribed.Nov 29 2016, 11:32 AM
SamanthaNguyen subscribed.Jan 23 2017, 4:46 AM
SamanthaNguyen mentioned this in T158618: SocialProfile Special:UpdateProfile should switch from jQuery UI Datepicker to PHP DateInputWidget.Feb 21 2017, 5:31 AM
Volker_E renamed this task from Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core (replacing it with OO UI). to Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core (replacing it with OOUI)..Nov 7 2017, 11:18 PM
Perhelion awarded a token.Dec 13 2017, 12:16 PM
Steinsplitter subscribed.Dec 13 2017, 12:18 PM
Perhelion subscribed.EditedDec 14 2017, 8:09 PM

I guess on Commons the module must be installed locally, as there are to much gadgets using this.

kaldari added a comment.Dec 14 2017, 8:40 PM

There are lots of gadgets on lots of wikis that use jQuery.ui. Regardless of whether MediaWiki itself uses jQuery.ui, I think it would still be a good idea to make it available as a module for gadgets indefinitely.

Jdforrester-WMF added a comment.Dec 14 2017, 9:16 PM
In T49145#3838533, @kaldari wrote:

There are lots of gadgets on lots of wikis that use jQuery.ui. Regardless of whether MediaWiki itself uses jQuery.ui, I think it would still be a good idea to make it available as a module for gadgets indefinitely.

Yeah, it's going to be hard for communities that don't actually have people supporting their gadgets (though that situation isn't really meant to happen), and it isn't appropriate yet for some edge cases to migrate to OOUI. However, at some point we're going to have to stop shipping it, and not just by moving it on-wiki.

Krinkle added a comment.EditedDec 14 2017, 9:36 PM
In T49145#3838533, @kaldari wrote:

There are lots of gadgets on lots of wikis that use jQuery.ui. Regardless of whether MediaWiki itself uses jQuery.ui, I think it would still be a good idea to make it available as a module for gadgets indefinitely.

For the record, keeping anything has a non-zero maintenance cost. In particular for jQuery UI because we're using an outdated version.

https://github.com/wikimedia/mediawiki/commits/317aa201/resources/lib/jquery.ui
https://github.com/wikimedia/mediawiki-skins-Vector/commits/d4eabd9d10/skinStyles/jquery.ui
https://github.com/wikimedia/mediawiki/blob/317aa201/resources/lib/jquery.ui/PATCHES
https://github.com/wikimedia/mediawiki-skins-Vector/blob/d4eabd9d10/skinStyles/jquery.ui/PATCHES

Given our version is now far beyond jQuery's LTS/EOL, we need to either start taking over maintenance of this legacy version as soon as possible (starting with an overdue security review), or we need to start migration to a newer version. It sounds like we want to avoid migration due to unmaintained gadgets (or we could encourage migration to OOUI). Although arguably migrating to a newer jQuery UI version should be much simpler compared to migrating to OOUI, either would require hands-on coding, and either would result in truly unmodified code to break.

I'm not proposing anything right now, but it should be unsurprising that we cannot indefinitely support unmaintained gadgets by indefinitely shipping upstream-unsupported software as-is, without maintenance or responsibility for finding and addressing likely security vulnerabilities.

Agabi10 subscribed.Dec 14 2017, 10:39 PM
• Prtksxna subscribed.Jan 4 2018, 3:26 AM
AndyRussG mentioned this in T185913: CentralNotice: Replace date picker and multiselect widgets with OOUI widgets in Admin UI.Jan 29 2018, 6:16 PM
Volker_E removed a parent task: T54775: jQuery UI 'x' close icons look awful in Firefox depending on zoom setting.Jul 31 2018, 1:02 PM
Jdlrobson mentioned this in T200868: [EPIC] Make jQuery an optional dependency.Aug 1 2018, 2:52 AM
Schnark subscribed.Dec 17 2018, 9:56 AM
Izno mentioned this in T215084: Stop depending on jQuery in OOUI.Feb 3 2019, 1:28 PM
Amorymeltzer subscribed.Mar 18 2019, 9:00 PM
Krinkle mentioned this in T219604: Remove unused jquery.ui.* and jquery.effects.* modules.Jul 30 2019, 12:11 AM
Lucas_Werkmeister_WMDE subscribed.Nov 20 2019, 4:50 PM
Yaron_Koren mentioned this in T241632: Remove use of jQuery UI from Page Forms.Dec 31 2019, 4:30 AM
• jbolorinos-ctr subscribed.Feb 20 2020, 5:15 PM
Snaevar subscribed.Mar 26 2022, 7:24 AM
Jdlrobson added a project: MediaWiki-User-Interface (deprecated JS libraries).Nov 17 2022, 10:08 PM
Jdlrobson renamed this task from Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core (replacing it with OOUI). to Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core.Nov 17 2022, 10:23 PM
Jdlrobson added a subtask: T208256: Pick PageTriage JavaScript/front end rewrite frameworks.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subtask: T187992: Convert MediaWiki extensions WikiLove and MassMessage to use OOUI.
Jdlrobson updated the task description. (Show Details)Nov 17 2022, 10:31 PM
egardner subscribed.Nov 17 2022, 10:32 PM
AnneT subscribed.Nov 17 2022, 10:32 PM
Jdlrobson updated the task description. (Show Details)Nov 17 2022, 10:35 PM
Jdlrobson added subtasks: T323330: CodeEditor should not use jQuery.UI, T323329: CodeMirror should not use jQuery.UI, T323328: DonationInterface should not use jQuery.UI, T323327: Drop use of jQuery.UI in GWToolset, T323326: RevisionSlider should not use jquery.ui, T209059: Replace WikiEditor widgets with OOUI-based (VisualEditor) components, T323311: [Proposed Epic] Migrate Wikilove front-end to Codex, T323333: Remove jQuery.UI from Wikidata or use a local version, T323332: Remove jQuery.UI from Extension:Translate or use a local version, T187487: LiquidThreads: code stewardship review, T224922: Code Stewardship Review: Collection Extension.
ldelench_wmf added a project: Design-System-Team (Design-System-Product-Roadmap).Nov 17 2022, 11:29 PM
Catrope updated the task description. (Show Details)Nov 18 2022, 12:47 AM
Lucas_Werkmeister_WMDE added a comment.Nov 18 2022, 11:37 AM

Perhaps it might make sense for Wikibase/Translate to have a localized version of this library wikibase.jquery.ui since they are not enabled on all wikis.

The part used by WikibaseClient is enabled on most wikis (all client wikis).

Novem_Linguae subscribed.Nov 18 2022, 10:51 PM
Jdlrobson moved this task from Backlog to jquery.ui on the MediaWiki-User-Interface (deprecated JS libraries) board.Nov 21 2022, 4:54 PM
Novem_Linguae added a subtask: T323552: Remove deprecated jquery.ui from PageTriage.Nov 22 2022, 8:58 AM
Novem_Linguae removed a subtask: T208256: Pick PageTriage JavaScript/front end rewrite frameworks.
Novem_Linguae updated the task description. (Show Details)
egardner moved this task from Design-System-Product-Roadmap to Following on the Design-System-Team board.Dec 20 2022, 11:14 PM
egardner edited projects, added Design-System-Team; removed Design-System-Team (Design-System-Product-Roadmap).
malberts subscribed.Mar 25 2023, 12:48 PM
TehKittyCat subscribed.Apr 20 2023, 1:11 AM
Dreamy_Jazz updated the task description. (Show Details)May 11 2023, 6:01 PM
Reedy closed subtask T323327: Drop use of jQuery.UI in GWToolset as Declined.May 19 2023, 8:16 PM
Jdlrobson updated the task description. (Show Details)May 20 2023, 12:13 PM
Jdlrobson merged a task: T337113: Remove jQuery.UI from MediaWiki production.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.May 20 2023, 12:18 PM

Change 921529 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/LiquidThreads@master] Remove jquery.ui and ability to drag threads

https://gerrit.wikimedia.org/r/921529

gerritbot added a project: Patch-For-Review.May 20 2023, 12:18 PM

Change 921531 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Collection@master] Collections are no longer sortable

https://gerrit.wikimedia.org/r/921531

Jdlrobson updated the task description. (Show Details)May 20 2023, 12:23 PM
Jdlrobson updated the task description. (Show Details)May 20 2023, 12:39 PM
Jdlrobson updated the task description. (Show Details)May 20 2023, 1:02 PM
Jdlrobson updated the task description. (Show Details)May 20 2023, 1:04 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jun 8 2023, 7:49 PM

Change 921529 abandoned by Jdlrobson:

[mediawiki/extensions/LiquidThreads@master] WIP: Remove jquery.ui and ability to drag threads

Reason:

https://gerrit.wikimedia.org/r/921529

gerritbot added a comment.Jun 14 2023, 5:24 PM

Change 921531 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Replace sortable with bare bones up and down arrows

https://gerrit.wikimedia.org/r/921531

Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 5:30 PM
Jdlrobson updated the task description. (Show Details)Jun 14 2023, 5:41 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 6:00 PM
Snaevar unsubscribed.Jun 15 2023, 2:43 PM
Nikerabbit changed the status of subtask T323332: Remove jQuery.UI from Extension:Translate or use a local version from Open to In Progress.Jul 4 2023, 8:41 AM
abi_ closed subtask T323332: Remove jQuery.UI from Extension:Translate or use a local version as Resolved.Aug 30 2023, 2:51 PM
Jdlrobson updated the task description. (Show Details)Sep 6 2023, 10:06 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Sep 15 2023, 5:48 PM

Change 957966 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Collection@master] Remove unused jquery.ui module

https://gerrit.wikimedia.org/r/957966

gerritbot added a project: Patch-For-Review.Sep 15 2023, 5:48 PM
gerritbot added a comment.Sep 15 2023, 9:26 PM

Change 957966 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Remove unused jquery.ui module

https://gerrit.wikimedia.org/r/957966

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2023, 9:30 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Sep 15 2023, 10:00 PM
Winston_Sung mentioned this in T349787: Dialog: Make dialog support various features like jQuery.ui.dialog.Oct 26 2023, 3:32 AM
Volker_E removed a project: UI-Standardization.Feb 6 2024, 1:50 PM
TheDJ closed subtask T323311: [Proposed Epic] Migrate Wikilove front-end to Codex as Resolved.Mar 18 2024, 9:47 PM
TheDJ closed subtask T187992: Convert MediaWiki extensions WikiLove and MassMessage to use OOUI as Resolved.Mar 18 2024, 9:50 PM
MusikAnimal closed subtask T323329: CodeMirror should not use jQuery.UI as Resolved.Mon, Mar 25, 8:00 PM
Krinkle added a project: Technical-Debt (Deprecation process).Wed, Mar 27, 6:45 PM
Krinkle moved this task from Untriaged to Not yet on the Technical-Debt (Deprecation process) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL