Page MenuHomePhabricator
Create Task
Maniphest T49161

UploadWizard fails badly with jshint
Closed, ResolvedPublic
Actions

Description

See https://integration.wikimedia.org/ci/job/mwext-UploadWizard-jslint/93/checkstyleResult/source.22237/#14

Version: unspecified
Severity: normal

Details

Reference
bz47161

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:32 AM
• bzimport added a project: UploadWizard.
• bzimport set Reference to bz47161.
yuvipanda created this task.Apr 12 2013, 9:03 AM
Krenair added a comment.Apr 13 2013, 11:05 PM

https://github.com/wikimedia/mediawiki-extensions-UploadWizard/pull/1

(Yuvi is going to use this to test his new GH->Gerrit system)

gerritbot added a comment.Apr 13 2013, 11:19 PM

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

gerritbot added a comment.Apr 13 2013, 11:19 PM

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

gerritbot added a comment.Apr 13 2013, 11:19 PM

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

gerritbot added a comment.Apr 13 2013, 11:19 PM

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

gerritbot added a comment.Apr 13 2013, 11:19 PM

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

gerritbot added a comment.Apr 13 2013, 11:19 PM

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

gerritbot added a comment.Apr 13 2013, 11:19 PM

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

yuvipanda added a comment.Apr 13 2013, 11:44 PM

Don't merge yet, this shall be nice testing grounds for https://github.com/yuvipanda/SuchABot :)

gerritbot added a comment.Apr 15 2013, 5:52 AM

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

gerritbot added a comment.Apr 15 2013, 5:52 AM

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

gerritbot added a comment.Apr 15 2013, 5:52 AM

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

gerritbot added a comment.Apr 15 2013, 5:52 AM

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

gerritbot added a comment.Apr 15 2013, 5:52 AM

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

gerritbot added a comment.Apr 15 2013, 5:52 AM

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

gerritbot added a comment.Apr 15 2013, 5:52 AM

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

gerritbot added a comment.Apr 15 2013, 6:55 AM

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

gerritbot added a comment.Apr 15 2013, 6:55 AM

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

gerritbot added a comment.Apr 15 2013, 6:55 AM

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

gerritbot added a comment.Apr 15 2013, 6:55 AM

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

gerritbot added a comment.Apr 15 2013, 6:55 AM

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

gerritbot added a comment.Apr 15 2013, 6:55 AM

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

gerritbot added a comment.Apr 15 2013, 6:55 AM

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

MarkTraceur added a comment.Aug 15 2013, 8:51 PM

It looks like there's still significant amounts of work to do on this - should I leave you assigned, Krenair, or do you want to pass this on to the crowd?

MarkTraceur added a comment.Aug 21 2013, 6:34 PM

Tooo late. I started a big ol' patch to fix things. I may split it up later if asked nicely.

Krenair added a comment.Aug 21 2013, 8:35 PM

Sorry, I kept meaning to reply to this but never got around to it. Please 'pass this on to the crowd' :)

gerritbot added a comment.Aug 23 2013, 12:56 AM

Change 80523 had a related patch set uploaded by MarkTraceur:
Loads of work on jshint fixes

https://gerrit.wikimedia.org/r/80523

gerritbot added a comment.Aug 26 2013, 12:16 AM

Change 80945 had a related patch set uploaded by MarkTraceur:
More jshint fixes

https://gerrit.wikimedia.org/r/80945

gerritbot added a comment.Aug 26 2013, 1:20 AM

Change 80947 had a related patch set uploaded by MarkTraceur:
Further jshint fixes

https://gerrit.wikimedia.org/r/80947

gerritbot added a comment.Aug 27 2013, 12:34 AM

Change 80523 merged by jenkins-bot:
Loads of work on jshint fixes

https://gerrit.wikimedia.org/r/80523

MarkTraceur added a comment.Aug 27 2013, 8:40 PM

Once the patches in gerrit are merged, we can mark this bug as fixed and make the jshint job voting in Jenkins. Exciting!

gerritbot added a comment.Oct 1 2013, 12:00 AM

Change 80954 had a related patch set uploaded by MarkTraceur:
Further jshint fixes

https://gerrit.wikimedia.org/r/80954

gerritbot added a comment.Oct 1 2013, 12:07 AM

Change 86776 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.ConfirmCloseWindow.js

https://gerrit.wikimedia.org/r/86776

gerritbot added a comment.Oct 1 2013, 12:07 AM

Change 86777 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/86777

gerritbot added a comment.Oct 1 2013, 12:08 AM

Change 86778 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDescription.js

https://gerrit.wikimedia.org/r/86778

gerritbot added a comment.Oct 1 2013, 12:10 AM

Change 86779 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDetails.js

https://gerrit.wikimedia.org/r/86779

gerritbot added a comment.Oct 1 2013, 12:11 AM

Change 80945 abandoned by MarkTraceur:
More jshint fixes

Reason:
Split into:

  • If3023606e187afd3ac49739de7545f4fd3ba60f4
  • I66a32316613a0779a7ca3a5b77698cacca1ba11f
  • Iafb382ca73652b254e097dce7521eee6a783a504
  • If7e2ab0fc347841ead3073bc63ba85b4a96795ab

https://gerrit.wikimedia.org/r/80945

gerritbot added a comment.Oct 1 2013, 1:16 AM

Change 86789 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/86789

gerritbot added a comment.Oct 1 2013, 1:17 AM

Change 86787 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/86787

gerritbot added a comment.Oct 1 2013, 1:18 AM

Change 80947 abandoned by MarkTraceur:
Further jshint fixes

Reason:
Split into:

  • I3552fcb0ccd4902c3cd02f2c6eb133b752e3d1ff
  • I1c54a2c2f82dcddf8bdfa63ff80b320744aa6b2f

https://gerrit.wikimedia.org/r/80947

gerritbot added a comment.Oct 1 2013, 1:26 AM

Change 86791 had a related patch set uploaded by MarkTraceur:
Ignore unused jasmine tests for jshint

https://gerrit.wikimedia.org/r/86791

gerritbot added a comment.Oct 1 2013, 1:26 AM

Change 86792 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardPage.js

https://gerrit.wikimedia.org/r/86792

gerritbot added a comment.Oct 1 2013, 1:27 AM

Change 86793 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUploadInterface.js

https://gerrit.wikimedia.org/r/86793

gerritbot added a comment.Oct 1 2013, 1:27 AM

Change 86794 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUtil.js

https://gerrit.wikimedia.org/r/86794

gerritbot added a comment.Oct 1 2013, 1:27 AM

Change 86797 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UtilitiesTime.js

https://gerrit.wikimedia.org/r/86797

gerritbot added a comment.Oct 1 2013, 1:28 AM

Change 86798 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.fileApi.js

https://gerrit.wikimedia.org/r/86798

gerritbot added a comment.Oct 1 2013, 2:28 AM

Change 80954 merged by jenkins-bot:
Further jshint fixes

https://gerrit.wikimedia.org/r/80954

gerritbot added a comment.Oct 1 2013, 2:30 AM

Change 86793 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardUploadInterface.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86793

gerritbot added a comment.Oct 1 2013, 2:31 AM

Change 86794 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardUtil.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86794

gerritbot added a comment.Oct 1 2013, 2:31 AM

Change 86797 abandoned by MarkTraceur:
jshint fixes for mw.UtilitiesTime.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86797

gerritbot added a comment.Oct 1 2013, 2:31 AM

Change 86798 abandoned by MarkTraceur:
jshint fixes for mw.fileApi.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86798

gerritbot added a comment.Oct 1 2013, 2:31 AM

Change 86792 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardPage.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86792

gerritbot added a comment.Oct 1 2013, 2:31 AM

Change 86791 abandoned by MarkTraceur:
Ignore unused jasmine tests for jshint

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86791

MarkTraceur added a comment.Oct 1 2013, 3:20 AM

Sorry about all of the notifications - might have been smart to have split this into multiple bugs...ah well, too late to turn back now!

gerritbot added a comment.Oct 6 2013, 11:51 PM

Change 86776 merged by jenkins-bot:
jshint fixes for mw.ConfirmCloseWindow.js

https://gerrit.wikimedia.org/r/86776

gerritbot added a comment.Oct 6 2013, 11:55 PM

Change 86778 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDescription.js

https://gerrit.wikimedia.org/r/86778

Aklapper added a comment.Feb 17 2014, 7:23 PM

Ignoring MERGED and ABANDONED patchsets in Gerrit, this is what is left here:
https://gerrit.wikimedia.org/r/#/c/86777/
https://gerrit.wikimedia.org/r/#/c/86779/
https://gerrit.wikimedia.org/r/#/c/86789/
https://gerrit.wikimedia.org/r/#/c/86787/

MarkTraceur added a comment.Mar 25 2014, 12:35 AM
  • Bug 61642 has been marked as a duplicate of this bug. ***
gerritbot added a comment.May 2 2014, 8:41 AM

Change 86787 merged by jenkins-bot:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/86787

gerritbot added a comment.May 6 2014, 11:56 AM

Change 86789 merged by jenkins-bot:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/86789

gerritbot added a comment.May 6 2014, 12:02 PM

Change 86779 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDetails.js

https://gerrit.wikimedia.org/r/86779

gerritbot added a comment.May 6 2014, 12:12 PM

Change 131685 had a related patch set uploaded by Gilles:
Fix missed jshint issues

https://gerrit.wikimedia.org/r/131685

gerritbot added a comment.May 6 2014, 12:14 PM

Change 131685 merged by jenkins-bot:
Fix missed jshint issues

https://gerrit.wikimedia.org/r/131685

gerritbot added a comment.May 6 2014, 12:21 PM

Change 131686 had a related patch set uploaded by Gilles:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/131686

gerritbot added a comment.May 7 2014, 12:47 PM

Change 131686 merged by jenkins-bot:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/131686

MarkTraceur added a comment.May 19 2014, 5:54 PM

Poke (for Yuvi)

MarkTraceur added a comment.May 19 2014, 5:58 PM

Sigh yuvi, poking again

MarkTraceur added a comment.May 19 2014, 6:01 PM

Stop failing yuvi

gerritbot added a comment.May 20 2014, 7:04 AM

Change 86777 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/86777

hashar added a comment.May 20 2014, 1:24 PM

So apparently UploadWizard pass the Jenkins job jslint which runs JSHint. Should we consider this bug fixed and make the job voting? :-)

gerritbot added a comment.May 22 2014, 8:25 AM

Change 134791 had a related patch set uploaded by Gilles:
Make jslint voting for UploadWizard

https://gerrit.wikimedia.org/r/134791

gerritbot added a comment.May 22 2014, 8:26 AM

Change 134791 merged by jenkins-bot:
Make jslint voting for UploadWizard

https://gerrit.wikimedia.org/r/134791

hashar added a comment.May 22 2014, 8:34 AM

There is nothing left to do now :-) Congratulations!

Krenair added a comment.May 22 2014, 10:50 AM

Yay.

tomasz added a comment.May 22 2014, 9:46 PM

Amazing job everyone! Woo-hoo!

gerritbot added a comment.Jun 21 2014, 12:15 PM

Change 141190 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/141190

gerritbot added a comment.Jun 21 2014, 12:15 PM

Change 141195 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/141195

gerritbot added a comment.Jun 21 2014, 12:15 PM

Change 141198 had a related patch set uploaded by Inchikutty:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/141198

gerritbot added a comment.Jun 21 2014, 12:15 PM

Change 141209 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/141209

gerritbot added a comment.Jun 21 2014, 2:19 PM

Change 141209 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/141209

gerritbot added a comment.Jun 21 2014, 2:20 PM

Change 141198 abandoned by Alex Monk:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/141198

gerritbot added a comment.Jun 21 2014, 2:22 PM

Change 141195 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/141195

gerritbot added a comment.Jun 21 2014, 2:22 PM

Change 141190 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/141190

Krenair added a comment.Jun 21 2014, 2:27 PM

(Someone reuploaded every change since what appeared to be the 26th of Febuary. I have cleaned them up.)

• Gilles added a project: Multimedia.Dec 4 2014, 9:35 AM
• Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.
• Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:21 AM
matmarex mentioned this in T55248: Use OOJS for JavaScript inheritance in mw.UploadWizardDeed subclasses.Oct 26 2015, 1:39 PM
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 7:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL