Created attachment 12097
Patch rather than file

Attached:

Please note we do not maintain the GeSHi component, this is done at http://sourceforge.net/projects/geshi/, so questions about why it is lsl2 should be directed to http://sourceforge.net/p/geshi/_list/tickets

I do have commit rights on that repository, but the file you have provided looks a lot different from the lsl2.php at http://sourceforge.net/p/geshi/code/HEAD/tree/trunk/geshi-1.0.X/src/geshi/lsl2.php - Where did you get your original version from?

I've attached a proper diff file of what you have provided, versus the file above. Although the majority of the changes look sane, I'm pretty hesitant about the removal of parts from the header, such as the author details

jobinmunich wrote:

The file you linked is the one I modified.

Could ask William about lsl2 vs. lsl...

The great diff mainly comes from mistakes in the original file (like division being done via forward slash, not colon) but even more so because the Linden Scripting Language has evolved between 2009 and today.

On another note, the URLs at the end of the file were linking to a non-official wiki. I'm not sure that is a good idea, even though some people prefer lslwiki. The problem is, lslwiki isn't as up to date and it's third party.

Found {FNAME} missing in the URLs, attached fixed file.
Modified colors to match original more closely.

jobinmunich wrote:

update for the Linden Scripting Language syntax highlight as of 2013-04-14

attachment linden_scripting_language_for_geshi.php ignored as obsolete

jobinmunich wrote:

update for the Linden Scripting Language syntax highlight as of 2013-04-14

LSL has multi-line comments.

States purple.
Escape characters orange.

Changed keyword list ordering and moved "default" and "state" to a states keyword array of their own.

attachment linden_scripting_language_for_geshi.php ignored as obsolete

jobinmunich wrote:

update for the Linden Scripting Language syntax highlight as of 2013-04-14

Color multi-line comments, too.

Attached:

Again, you haven't posted a diff, and you've still removing most of the header information, which is bad form. Some of the information in the header could probably be removed, but you shouldn't just remove it all.

jobinmunich wrote:

You got a diff tool, why would I have to post the diff here too ontop of the comments what I changed? If you'd rather put William's part in the header, go ahead.

Posting a diff provides relevant context for what was changed, versus a file. For anyone else to review it, they'd have to checkout the svn repo for geshi, replace the file with your version, then create a diff. Easier if you just provide a diff.

As for removing the header/author information like that, can be considered somewhat rude.

I'll also re-iterate that this isn't really the right place for posting a patch to a 3rd party library. If I didn't have commit access, and AFAIK I'm the only person in the MW community that does have commit access to geshi, someone would have to re-report it at the proper place of http://sourceforge.net/p/geshi/_list/tickets

Have you any further changes to make to it (you've posted 4 versions of it now)? If not, I can commit this version for the next GeSHi release, but I'd rather not have to make multiple commits to amend the change

jobinmunich wrote:

You can commit this version.

Committed upstream, 2576