Jenkins: jslint fails for some extensions and therefore translatewiki script breaks.
Version: wmf-deployment
Severity: normal
URL: https://gerrit.wikimedia.org/r/#/c/59206/
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52456
Description
Description
Details
Details
- Reference
- bz47260
Event Timeline
Comment Actions
AbuseFilter jslint job failed : https://integration.wikimedia.org/ci/job/mwext-AbuseFilter-jslint/80/
Although the previous patchset ( https://gerrit.wikimedia.org/r/#/c/58755/ ) has been merged by the gate-and-submit pipeline (ie test used to work).
Comment Actions
The immediate problem has been fixed by adding the files to the extensions that had jshint enabled but were missing a jshintrc file.
For the future I'll add a check in the jenkins job asserting that a jshint configuration file exists before proceeding, that way the error will be "Missing .jshintrc file" instead of some arbitrary style violation that comes from the internal jshint defaults.
Comment Actions
I think the jobs started failing when we added a .jshintrc file in integration/docroot.git and/or had the Jenkins workspace has children of /srv/ . That is bug 52456.
Comment Actions
Projects that have jshint enabled must have a jshintrc file that contains actual rules (not something silly like {}).
If you don't have jshintrc, please don't enable jshint in Jenkins.