Page MenuHomePhabricator

Cloned Cite object does not clear if the parser was cloned inside a <ref> or <references>
Closed, ResolvedPublic

Description

If the parser is cloned inside a <ref> or <references> tag (e.g. if the first call to MessageCache::getParser() in the page is due to a message inside one of those tags), then the cloned Cite object created in Cite::cloneState() will have mInRef or mInReferences true and therefore the call to Cite::clearState() will not actually clear the Cite object.


Version: master
Severity: normal

Details

Reference
bz47291

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:41 AM
bzimport added a project: Cite.
bzimport set Reference to bz47291.

Related URL: https://gerrit.wikimedia.org/r/59508 (Gerrit Change Id3e91c41dc33a703b5326961fd57e1fe8ac61f5b)

https://gerrit.wikimedia.org/r/59508 (Gerrit Change Id3e91c41dc33a703b5326961fd57e1fe8ac61f5b) | change APPROVED and MERGED [by Aaron Schulz]