Page MenuHomePhabricator

VisualEditor: Allow users to set/edit #REDIRECT status in the page metadata panel
Closed, ResolvedPublic

Description

See bug 45808 for the corresponding Parsoid bug.

Currently editing a redirected page (say "OLPC") causes the following Bad Things to happen.

a) the edited page content is saved back to "OLPC", overwriting the original #REDIRECT

b) the page content is from "One Laptop Per Child", but with an added {{Redirect:OLPC}} template at the top; this extra template gets saved back with the rest of the edits.

In bug 45808, Parsoid will return a special <meta> or <link> tag in the body for redirected pages. This bug is for the corresponding VE support to recognize that tag and provide a user-friendly interface for editing redirects.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47329

Details

Reference
bz47328

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:14 AM
bzimport set Reference to bz47328.

This is probably a post-July task; have split off a "don't fail horribly" bug as bug 47329, linked.

Some quick advice on this one:

  • There'll need to be code in DM and UI; the code in Parsoid which it will interact with has just been merged into their master.
  • I'd suggest looking at how {{DEFAULTSORT}} works as a starting point - see https://gerrit.wikimedia.org/r/#/c/61374/ for the DM side.
  • On the UI side, you'd want to create a new panel in the meta-data dialog ("Page settings" is probably the best name, though that's also the display name of the dialog, but we can fiddle with that later) into which you'd put a checkbox with an associated text box for a page name, with auto-suggest (like the link inspector has).

Redirect editing disabled by https://gerrit.wikimedia.org/r/64275, will need to be re-enabled when this bug is addressed.

Assigning to Jiabao Wu as discussed on bug 48489 comment 4.

This is likely obvious to everyone, but: We need a way to create redirects in VisualEditor from redlinks.

VE is currently (02 July 2013) turned off for editing redirect pages at en.wikipedia.org. However, it's still possible to create these pages using VE, which end up nowiki-ed and broken.

It is also possible to fail to convert a non-redirect page into a redirect (e.g following a merge).

Change 95103 had a related patch set uploaded by Jforrester:
[WIP] Let users set #REDIRECT, NOTOC, & FORCETOC

https://gerrit.wikimedia.org/r/95103

Change 95213 had a related patch set uploaded by Jforrester:
[WIP] Let users set #REDIRECT

https://gerrit.wikimedia.org/r/95213

Change 95213 merged by jenkins-bot:
Let users set #REDIRECT and STATICREDIRECT status

https://gerrit.wikimedia.org/r/95213

(In reply to Gerrit Notification Bot from comment #10)

Neat! Is there documentation about this panel and/or a place to test it?