Page MenuHomePhabricator

Make MobileFrontend use mediawiki.ui button styles
Closed, DeclinedPublic

Description

Author: massaf

Description:
Jon Robson requested that we track this in a different bug (we were previously discussing it in #46804, which is focused on button heights).

There are several buttons scattered throughout MobileFrontend that aren't using the latest mediawiki.ui buttons which can be found in MW core. In general, button styles are inconsistently applied in MobileFrontend and we need to make sure that errant styles aren't tweaking things.

See #46804 for a specific example and related discussion.


Version: unspecified
Severity: enhancement

Details

Reference
bz47330

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:14 AM
bzimport set Reference to bz47330.
bzimport added a subscriber: Unknown Object (MLST).

mediawiki.ui.default.css seems to use classes such as .mw-ui-button
In MobileFrontend we simply style the button tag to keep things simpler.

Do we want to add classes such as mw-ui-button?

Marking as enhancement for time being.

Thinking about this some more a long term goal might be to use the same mixins to generate the button styles. I'm not sure however what advantage this has at the moment and since the source files used to generate css for mediawiki.ui buttons is written in Sass and we use Less this will take some time.

Since I don't see the real advantage at this time (the Vector skin and the Minerva skin are very different) I think doing this would not be of value to either projects - Vector needs more specific css rules and cares about IE6, Minerva needs more minimal ones and doesn't care so much about IE6.